From: Wen Gong <wgong@codeaurora.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] ath10k: add fw coredump for sdio when firmware assert
Date: Mon, 23 Sep 2019 19:07:07 +0800 [thread overview]
Message-ID: <706142499b2f13de278262f3c52c2047@codeaurora.org> (raw)
In-Reply-To: <878sqhc25h.fsf@codeaurora.org>
On 2019-09-21 19:35, Kalle Valo wrote:
>
> The commit log tells nothing about fast, it should always document the
> design decisions. Why this fast dump, what's the benefit? Why not
> always
> use the fast dump and forget the slow dump (or vice versa)? There needs
> to be really good reasons to have all this complexity to support both
> slow and fast dumps.
fastdump is new added in fimrware of sdio, so if it is use old firmeare,
then it will
not support fastdump, then it need to use slow dump type.
it is to compatibility for old/new version firmware.
>
>> + ath10k_err(ar, "check fw reg : %x\n", param);
>> +}
>
> This is a debug message, not an error. And debug messages should use
> format "sdio hi_option_flag2 %x\n".
next prev parent reply other threads:[~2019-09-23 11:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 2:32 [PATCH v2] ath10k: add fw coredump for sdio when firmware assert Wen Gong
2019-09-21 11:26 ` Kalle Valo
2019-09-21 11:35 ` Kalle Valo
2019-09-23 11:07 ` Wen Gong [this message]
2019-09-24 3:38 ` Wen Gong
2019-09-21 11:38 ` Kalle Valo
2019-09-23 11:09 ` Wen Gong
2019-09-23 11:37 ` Kalle Valo
2019-09-23 12:12 ` Wen Gong
2019-09-21 11:49 ` Kalle Valo
2019-09-23 11:10 ` Wen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=706142499b2f13de278262f3c52c2047@codeaurora.org \
--to=wgong@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).