Linux wireless drivers development
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Ren Wei <n05ec@lzu.edu.cn>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "johannes@sipsolutions.net" <johannes@sipsolutions.net>,
	"nbd@openwrt.org" <nbd@openwrt.org>,
	"linville@tuxdriver.com" <linville@tuxdriver.com>,
	"yuantan098@gmail.com" <yuantan098@gmail.com>,
	"zcliangcn@gmail.com" <zcliangcn@gmail.com>,
	"bird@lzu.edu.cn" <bird@lzu.edu.cn>,
	"xuyuqiabc@gmail.com" <xuyuqiabc@gmail.com>
Subject: RE: [PATCH 1/1] wifi: mac80211: validate minstrel HT tx status rates
Date: Tue, 26 May 2026 02:43:28 +0000	[thread overview]
Message-ID: <710745062b5f4323a233db0cd4288ced@realtek.com> (raw)
In-Reply-To: <0e3f97ca5cfbeb67a8e60ca5c266f4335950816b.1779619788.git.xuyq21@lenovo.com>

Ren Wei <n05ec@lzu.edu.cn> wrote:
> @@ -1205,8 +1242,9 @@ minstrel_ht_txstat_valid(struct minstrel_priv *mp, struct minstrel_ht_sta *mi,
>         if (!rate->count)
>                 return false;
> 
> -       if (rate->flags & IEEE80211_TX_RC_MCS ||
> -           rate->flags & IEEE80211_TX_RC_VHT_MCS)

Miss a line?
- 		return true;


> +       if (rate->flags & IEEE80211_TX_RC_MCS ||
> +           rate->flags & IEEE80211_TX_RC_VHT_MCS)
> +               return minstrel_ht_txstat_valid_rate(rate);
> 
>         for (i = 0; i < ARRAY_SIZE(mp->cck_rates); i++)
> @@ -1235,8 +1273,9 @@ minstrel_ht_ri_txstat_valid(struct minstrel_priv *mp,
>         if (!rate_status->try_count)
>                 return false;
> 
> -       if (rate_status->rate_idx.flags & RATE_INFO_FLAGS_MCS ||
> -           rate_status->rate_idx.flags & RATE_INFO_FLAGS_VHT_MCS)

Miss a line?

-		return true;

> +       if (rate_status->rate_idx.flags & RATE_INFO_FLAGS_MCS ||
> +           rate_status->rate_idx.flags & RATE_INFO_FLAGS_VHT_MCS)
> +               return minstrel_ht_ri_txstat_valid_rate(&rate_status->rate_idx);
> 
>         for (i = 0; i < ARRAY_SIZE(mp->cck_rates); i++) {
> --
> 2.54.0
> 


  reply	other threads:[~2026-05-26  2:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1779619788.git.xuyq21@lenovo.com>
2026-05-25 11:07 ` [PATCH 1/1] wifi: mac80211: validate minstrel HT tx status rates Ren Wei
2026-05-26  2:43   ` Ping-Ke Shih [this message]
2026-05-26  3:39     ` Ren Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=710745062b5f4323a233db0cd4288ced@realtek.com \
    --to=pkshih@realtek.com \
    --cc=bird@lzu.edu.cn \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=n05ec@lzu.edu.cn \
    --cc=nbd@openwrt.org \
    --cc=xuyuqiabc@gmail.com \
    --cc=yuantan098@gmail.com \
    --cc=zcliangcn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox