public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: MeiChia Chiu <MeiChia.Chiu@mediatek.com>, Felix Fietkau <nbd@nbd.name>
Cc: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
	Shayne Chen <shayne.chen@mediatek.com>,
	Evelyn Tsai <evelyn.tsai@mediatek.com>,
	Ryder Lee <ryder.lee@mediatek.com>,
	Money Wang <Money.Wang@mediatek.com>,
	linux-wireless@vger.kernel.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] mt76: mt7915: add mu-mimo and ofdma debugfs knobs
Date: Mon, 6 Dec 2021 08:43:36 -0800	[thread overview]
Message-ID: <7158a937-57f3-2bd8-591e-124a18d2d8e8@candelatech.com> (raw)
In-Reply-To: <20211206141006.29632-1-MeiChia.Chiu@mediatek.com>

On 12/6/21 6:10 AM, MeiChia Chiu wrote:
> From: MeiChia Chiu <meichia.chiu@mediatek.com>
> 
> Add mu-mimo and ofdma packet counters statistics.

Hello,

Are these stats clear-on-read in the firmware?  If so, then we need to accumulate
them in the driver.

Is there any significant downside to enabling the stats?  For instance, a performance
degradation in the firmware/hardware?

Thanks,
Ben

> 
> Reviewed-by: Money Wang <money.wang@mediatek.com>
> Reviewed-by: Ryder Lee <ryder.lee@mediatek.com>
> Signed-off-by: MeiChia Chiu <meichia.chiu@mediatek.com>
> ---
>   .../net/wireless/mediatek/mt76/mt7915/debugfs.c | 242 ++++++++++++++++++++++++++++++++++++++++++++++-
>   .../net/wireless/mediatek/mt76/mt7915/mcu.c     |  41 ++++++++
>   .../net/wireless/mediatek/mt76/mt7915/mcu.h     |  45 +++++++++
>   .../net/wireless/mediatek/mt76/mt7915/mt7915.h  |   3 +
>   4 files changed, 330 insertions(+), 1 deletion(-)
> 


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

  reply	other threads:[~2021-12-06 16:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-06 14:10 [PATCH] mt76: mt7915: add mu-mimo and ofdma debugfs knobs MeiChia Chiu
2021-12-06 16:43 ` Ben Greear [this message]
2021-12-07  7:25   ` meichia chiu
2021-12-07 15:33     ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7158a937-57f3-2bd8-591e-124a18d2d8e8@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=MeiChia.Chiu@mediatek.com \
    --cc=Money.Wang@mediatek.com \
    --cc=evelyn.tsai@mediatek.com \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo.bianconi@redhat.com \
    --cc=nbd@nbd.name \
    --cc=ryder.lee@mediatek.com \
    --cc=shayne.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox