From: Hin-Tak Leung <htl10@users.sourceforge.net>
To: Xose Vazquez Perez <xose.vazquez@gmail.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
herton@mandriva.com.br, Larry.Finger@lwfinger.net
Subject: Re: [PATCH 1/2] wireless: rtl818x: rtl8180: add ids
Date: Sat, 15 May 2010 11:21:28 +0000 (GMT) [thread overview]
Message-ID: <717061.22086.qm@web23103.mail.ird.yahoo.com> (raw)
In-Reply-To: <4BEE7AB0.2090206@gmail.com>
--- On Sat, 15/5/10, Xose Vazquez Perez <xose.vazquez@gmail.com> wrote:
> Sorry, but no realtek devices here.
I am sorry, if you do not own any of the devices for which you just copied a bunch of IDs from the windows driver, that means your patch is untested. What is your purpose of copying IDs from the windows driver?
There is no code sharing between the windows driver and the linux driver, and there are at least 5 variants of the device - so what the windows driver supports really bears no relationship with what the linux driver supports.
I don't think it is a good idea to blindly copy IDs from the windows driver without testing.
next prev parent reply other threads:[~2010-05-15 11:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 23:49 [PATCH 1/2] wireless: rtl818x: rtl8180: add ids Hin-Tak Leung
2010-05-15 10:42 ` Xose Vazquez Perez
2010-05-15 11:21 ` Hin-Tak Leung [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-05-14 23:44 Xose Vazquez Perez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=717061.22086.qm@web23103.mail.ird.yahoo.com \
--to=htl10@users.sourceforge.net \
--cc=Larry.Finger@lwfinger.net \
--cc=herton@mandriva.com.br \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=xose.vazquez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox