Re: [PATCH 1/3] Fix overread in PREQ frame processing

[Johannes Berg <johannes@sipsolutions.net>]

On Mon, 2026-05-11 at 17:58 +0900, Masashi Honma wrote:
> > This isn't really right since u32_field_get() exists only within
> > mesh_hwmp.c ... it's probably better to modernise all this while at it:
> 
> Ah, yes. Both the build and tests passed, so I overlooked it.

Yes, it would, but it's basically not self-contained. More of a code
hygiene issue I guess than a real problem right now.

> > and restructure the code accordingly?
> > Anyway, I dunno. Maybe we should just go with your original patch for
> > now. Maybe I'm also asking more of you than others because you have an
> > LLM to help ;-)
> 
> If it is not urgent, I would like to proceed with the requested restructuring.

Oh sure, as far as I'm concerned there's no urgency, I just didn't want
to keep asking you to make changes too much.

> Actually, I only used the LLM to find potential vulnerabilities, and I wrote
> the code myself :)

Oh OK :) Maybe we need that as a kind of Reported-by? Hmm.

Or you could send a separate bug report email, say there Claude found
it, and then do a Closes: link :-p

johannes