From: <samuel@sortiz.org>
To: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] iwl3945: Remove unused variables
Date: Mon, 19 Jan 2009 14:06:23 +0100 [thread overview]
Message-ID: <726c7ab86fd8a193ef621bac113b0ab4@localhost> (raw)
In-Reply-To: <200901190955.32818.helmut.schaa@gmail.com>
On Mon, 19 Jan 2009 09:55:32 +0100, Helmut Schaa=0D
<helmut.schaa@googlemail.com> wrote:=0D
> Fix the following warnings in iwl-3945-rs.c by removing unused variab=
les.=0D
> =0D
> drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function=0D
> =E2=80=98iwl3945_rate_scale_flush_windows=E2=80=99:=0D
> drivers/net/wireless/iwlwifi/iwl-3945-rs.c:186: warning: unused varia=
ble=0D
> =E2=80=98priv=E2=80=99=0D
> drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function=0D
> =E2=80=98iwl3945_bg_rate_scale_flush=E2=80=99:=0D
> drivers/net/wireless/iwlwifi/iwl-3945-rs.c:219: warning: unused varia=
ble=0D
> =E2=80=98priv=E2=80=99=0D
> drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function=0D
> =E2=80=98iwl3945_collect_tx_data=E2=80=99:=0D
> drivers/net/wireless/iwlwifi/iwl-3945-rs.c:293: warning: unused varia=
ble=0D
> =E2=80=98priv=E2=80=99=0D
> drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function=0D
=E2=80=98rs_free_sta=E2=80=99:=0D
> drivers/net/wireless/iwlwifi/iwl-3945-rs.c:441: warning: unused varia=
ble=0D
> =E2=80=98priv=E2=80=99=0D
> drivers/net/wireless/iwlwifi/iwl-3945-rs.c: In function=0D
> =E2=80=98iwl3945_get_adjacent_rate=E2=80=99:=0D
> drivers/net/wireless/iwlwifi/iwl-3945-rs.c:559: warning: unused varia=
ble=0D
> =E2=80=98priv=E2=80=99=0D
> =0D
> Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>=0D
Acked-by: Samuel Ortiz <samuel.ortiz@intel.com>=0D
=0D
Thanks Helmut.=0D
=0D
> ---=0D
> diff --git a/drivers/net/wireless/iwlwifi/iwl-3945-rs.c=0D
> b/drivers/net/wireless/iwlwifi/iwl-3945-rs.c=0D
> index ba64034..2af45f4 100644=0D
> --- a/drivers/net/wireless/iwlwifi/iwl-3945-rs.c=0D
> +++ b/drivers/net/wireless/iwlwifi/iwl-3945-rs.c=0D
> @@ -183,7 +183,6 @@ static int iwl3945_rate_scale_flush_windows(struc=
t=0D
> iwl3945_rs_sta *rs_sta)=0D
> int unflushed =3D 0;=0D
> int i;=0D
> unsigned long flags;=0D
> - struct iwl_priv *priv =3D rs_sta->priv;=0D
> =0D
> /*=0D
> * For each rate, if we have collected data on that rate=0D
> @@ -216,7 +215,6 @@ static int iwl3945_rate_scale_flush_windows(struc=
t=0D
> iwl3945_rs_sta *rs_sta)=0D
> static void iwl3945_bg_rate_scale_flush(unsigned long data)=0D
> {=0D
> struct iwl3945_rs_sta *rs_sta =3D (void *)data;=0D
> - struct iwl_priv *priv =3D rs_sta->priv;=0D
> int unflushed =3D 0;=0D
> unsigned long flags;=0D
> u32 packet_count, duration, pps;=0D
> @@ -290,7 +288,6 @@ static void iwl3945_collect_tx_data(struct=0D
> iwl3945_rs_sta *rs_sta,=0D
> {=0D
> unsigned long flags;=0D
> s32 fail_count;=0D
> - struct iwl_priv *priv =3D rs_sta->priv;=0D
> =0D
> if (!retries) {=0D
> IWL_DEBUG_RATE("leave: retries =3D=3D 0 -- should be at least 1\n"=
);=0D
> @@ -438,7 +435,6 @@ static void rs_free_sta(void *iwl_priv, struct=0D
> ieee80211_sta *sta,=0D
> {=0D
> struct iwl3945_sta_priv *psta =3D (void *) sta->drv_priv;=0D
> struct iwl3945_rs_sta *rs_sta =3D priv_sta;=0D
> - struct iwl_priv *priv =3D rs_sta->priv;=0D
> =0D
> psta->rs_sta =3D NULL;=0D
> =0D
> @@ -556,7 +552,6 @@ static u16 iwl3945_get_adjacent_rate(struct=0D
> iwl3945_rs_sta *rs_sta,=0D
> {=0D
> u8 high =3D IWL_RATE_INVALID;=0D
> u8 low =3D IWL_RATE_INVALID;=0D
> - struct iwl_priv *priv =3D rs_sta->priv;=0D
> =0D
> /* 802.11A walks to the next literal adjacent rate in=0D
> * the rate table */=0D
> --=0D
> To unsubscribe from this list: send the line "unsubscribe linux-wirel=
ess"=0D
> in=0D
> the body of a message to majordomo@vger.kernel.org=0D
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-01-19 13:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 8:55 [PATCH 2/2] iwl3945: Remove unused variables Helmut Schaa
2009-01-19 13:06 ` samuel [this message]
2009-01-21 19:23 ` John W. Linville
2009-01-22 10:44 ` Helmut Schaa
2009-01-22 11:28 ` Tomas Winkler
2009-01-22 19:08 ` Helmut Schaa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=726c7ab86fd8a193ef621bac113b0ab4@localhost \
--to=samuel@sortiz.org \
--cc=helmut.schaa@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).