From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67782C31E40 for ; Thu, 15 Aug 2019 10:21:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 090D0208C2 for ; Thu, 15 Aug 2019 10:21:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nbd.name header.i=@nbd.name header.b="MFgZoxnA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730412AbfHOKU7 (ORCPT ); Thu, 15 Aug 2019 06:20:59 -0400 Received: from nbd.name ([46.4.11.11]:37418 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729838AbfHOKU7 (ORCPT ); Thu, 15 Aug 2019 06:20:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tMeUb8si+j1iS2xMT25L1e6awA1oCR/WdbWUv5BZJVY=; b=MFgZoxnATqm6wP5g02iBYKO3T3 wpmN8RCImSaUxJC6T7w8iIf/KIh1auXJLB/2ylO2sgQ4F9FxE8hj1sCM2EQ8kK5LqnW3iIGdNiCTR iUk3mcOXPZA60TXTBb2gtXMPJUHueH973IDP+gYnCzCHHz9/pB841cnpn5g/uE5TENWI=; Received: from p54ae9443.dip0.t-ipconnect.de ([84.174.148.67] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1hyCsJ-0002ke-7z; Thu, 15 Aug 2019 12:20:55 +0200 Subject: Re: [PATCH 5.3] mt76: mt76x0e: don't use hw encryption for MT7630E To: Stanislaw Gruszka , Lorenzo Bianconi Cc: linux-wireless , Ryder Lee , Roy Luo References: <1565703400-10623-1-git-send-email-sgruszka@redhat.com> <20190815100936.GA21775@redhat.com> From: Felix Fietkau Openpgp: preference=signencrypt Autocrypt: addr=nbd@nbd.name; prefer-encrypt=mutual; keydata= mQGiBEah5CcRBADIY7pu4LIv3jBlyQ/2u87iIZGe6f0f8pyB4UjzfJNXhJb8JylYYRzIOSxh ExKsdLCnJqsG1PY1mqTtoG8sONpwsHr2oJ4itjcGHfn5NJSUGTbtbbxLro13tHkGFCoCr4Z5 Pv+XRgiANSpYlIigiMbOkide6wbggQK32tC20QxUIwCg4k6dtV/4kwEeiOUfErq00TVqIiEE AKcUi4taOuh/PQWx/Ujjl/P1LfJXqLKRPa8PwD4j2yjoc9l+7LptSxJThL9KSu6gtXQjcoR2 vCK0OeYJhgO4kYMI78h1TSaxmtImEAnjFPYJYVsxrhay92jisYc7z5R/76AaELfF6RCjjGeP wdalulG+erWju710Bif7E1yjYVWeA/9Wd1lsOmx6uwwYgNqoFtcAunDaMKi9xVQW18FsUusM TdRvTZLBpoUAy+MajAL+R73TwLq3LnKpIcCwftyQXK5pEDKq57OhxJVv1Q8XkA9Dn1SBOjNB l25vJDFAT9ntp9THeDD2fv15yk4EKpWhu4H00/YX8KkhFsrtUs69+vZQwbQcRmVsaXggRmll dGthdSA8bmJkQG5iZC5uYW1lPohgBBMRAgAgBQJGoeQnAhsjBgsJCAcDAgQVAggDBBYCAwEC HgECF4AACgkQ130UHQKnbvXsvgCgjsAIIOsY7xZ8VcSm7NABpi91yTMAniMMmH7FRenEAYMa VrwYTIThkTlQuQINBEah5FQQCACMIep/hTzgPZ9HbCTKm9xN4bZX0JjrqjFem1Nxf3MBM5vN CYGBn8F4sGIzPmLhl4xFeq3k5irVg/YvxSDbQN6NJv8o+tP6zsMeWX2JjtV0P4aDIN1pK2/w VxcicArw0VYdv2ZCarccFBgH2a6GjswqlCqVM3gNIMI8ikzenKcso8YErGGiKYeMEZLwHaxE Y7mTPuOTrWL8uWWRL5mVjhZEVvDez6em/OYvzBwbkhImrryF29e3Po2cfY2n7EKjjr3/141K DHBBdgXlPNfDwROnA5ugjjEBjwkwBQqPpDA7AYPvpHh5vLbZnVGu5CwG7NAsrb2isRmjYoqk wu++3117AAMFB/9S0Sj7qFFQcD4laADVsabTpNNpaV4wAgVTRHKV/kC9luItzwDnUcsZUPdQ f3MueRJ3jIHU0UmRBG3uQftqbZJj3ikhnfvyLmkCNe+/hXhPu9sGvXyi2D4vszICvc1KL4RD aLSrOsROx22eZ26KqcW4ny7+va2FnvjsZgI8h4sDmaLzKczVRIiLITiMpLFEU/VoSv0m1F4B FtRgoiyjFzigWG0MsTdAN6FJzGh4mWWGIlE7o5JraNhnTd+yTUIPtw3ym6l8P+gbvfoZida0 TspgwBWLnXQvP5EDvlZnNaKa/3oBes6z0QdaSOwZCRA3QSLHBwtgUsrT6RxRSweLrcabiEkE GBECAAkFAkah5FQCGwwACgkQ130UHQKnbvW2GgCfTKx80VvCR/PvsUlrvdOLsIgeRGAAn1ee RjMaxwtSdaCKMw3j33ZbsWS4 Message-ID: <727fd528-16c1-e3b3-e1a9-2edbcbdddee7@nbd.name> Date: Thu, 15 Aug 2019 12:20:54 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190815100936.GA21775@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2019-08-15 12:09, Stanislaw Gruszka wrote: >> Hi Stanislaw, >> >> Can you please try if disabling/enabling the tx tasklet during hw key >> configuration fixes the issue? >> Doing something like: >> >> tasklet_disable(tx_tasklet) >> mt76x02_set_key() >> tasklet_enable(tx_tasklet) > > It does not help with the problem. > >> Moreover, have you double checked if there is any performance impact >> of not using hw encryption? > > I didn't observe any, but realized on this machine I have > aesni_intel encryption accelerator. After rebuild kernel without > CONFIG_CRYPTO_AES_NI_INTEL, 'perf top' showed extra 20% of cpu usage > in aes_encrypt() when sending data with HW encryption disabled. > >> If so, I guess it is better to just redefine mt76_wake_tx_queue for >> mt76x0e and run mt76_txq_schedule for 7630e: >> >> void mt76x0e_wake_tx_queue(struct ieee80211_hw *hw, struct ieee80211_txq *txq) >> { >> if (is_mt7630(dev)) { >> mt76_txq_schedule(dev, txq->ac); >> } else { >> tasklet_schedule(&dev->tx_tasklet); >> } >> } > > Not sure about reduction of lock contention for which the tx_tasklet > was introduced here, but looks ok for me as fix. I think if we work around the bug like this, it can easily come back to bite us again later. I don't see any logical explanation as to how this makes a difference with hardware encryption. Also, I think it would be helpful to figure out what key operation (if any) triggers this, adding or removing keys. Maybe it could also help if we change the order in which the WCID table entries are updated, i.e. changing MT_WCID_ATTR first when removing keys. Maybe temporarily clearing MT_MAC_SYS_CTRL_ENABLE_TX before the key update and setting it again afterwards could also help. - Felix