Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Manish Dharanenthiran <manish.dharanenthiran@oss.qualcomm.com>
Cc: linux-wireless@vger.kernel.org,
	Hari Naraayana Desikan Kannan <hnaraaya@qti.qualcomm.com>
Subject: Re: [PATCH wireless-next] wifi: mac80211: Fix ADDBA request rejection after MLD link removal
Date: Mon, 11 May 2026 10:46:19 +0200	[thread overview]
Message-ID: <72b480830dee1489bc28246d13102048635de5db.camel@sipsolutions.net> (raw)
In-Reply-To: <dbb28e3e-5022-4915-93e3-dd428ea59507@oss.qualcomm.com>

On Mon, 2026-05-11 at 11:56 +0530, Manish Dharanenthiran wrote:
> No, there is no implementations that combine these two, but there are 
> cases where the update AddBA request can be received from the station 
> with link reconfiguration.
> 
> For instance, if a station associated in 2 GHz, later with link 
> reconfiguration station can either move to 5 GHz or it can add 5 GHz (as 
> MLD). Station then can send a AddBA request to update the window size or 
> other related parameters.

Ah, well, OK - technically an implementation can do that all the time
(and technically we can refuse it all the time), but I guess then that
some implementations do it with link reconfiguration, and also don't
like the refusal :)

> 
> We believe that a no-op update is not required (or at-least we couldn't 
> think of a case in which that is actually needed) as there can might be 
> an actual change in the subsequent AddBA request.

I just think that once we require an UPDATE call from the driver, that
raises the question of whether we should even call it for a no-op. This
seems a bit strange? And if we don't then we wouldn't require it for no-
ops either, which is probably generally good for drivers that don't
(immediately) implement the UPDATE.

johannes

  reply	other threads:[~2026-05-11  8:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-15  6:51 [PATCH wireless-next] wifi: mac80211: Fix ADDBA request rejection after MLD link removal Manish Dharanenthiran
2026-04-27 10:00 ` Johannes Berg
2026-04-29 14:09   ` Manish Dharanenthiran
2026-05-07 18:26     ` Johannes Berg
2026-05-11  6:26       ` Manish Dharanenthiran
2026-05-11  8:46         ` Johannes Berg [this message]
2026-05-11 10:10           ` Manish Dharanenthiran
2026-05-11 10:11             ` Johannes Berg
2026-05-11 10:32               ` Manish Dharanenthiran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72b480830dee1489bc28246d13102048635de5db.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=hnaraaya@qti.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=manish.dharanenthiran@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox