From: Hin-Tak Leung <htl10@users.sourceforge.net>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Kalle Valo <kvalo@codeaurora.org>,
<linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
Colin King <colin.king@canonical.com>
Cc: <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rtlwifi: rtl818x: remove redundant check for cck_power > 15
Date: Mon, 4 Dec 2017 22:57:55 +0000 (UTC) [thread overview]
Message-ID: <734417985.2789125.1512428275673@mail.yahoo.com> (raw)
In-Reply-To: 734417985.2789125.1512428275673.ref@mail.yahoo.com
--------------------------------------------
On Tue, 14/11/17, Colin King <colin.king@canonical.com> wrote:
=20
> From: Colin Ian King <colin.king@canonical.com>
=20
> cck_poweri cannot be greated than 15 as
> is derived from the bottom 4 bits
> from riv->channels[channel -
> 1].hw_value & 0xf.=C2=A0 Hence the check for it
> being greater than 15 is redundant and
> can be removed.
=20
> Detected by CoverityScan, CID#744303
> ("Logically dead code")
=20
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
=20
Acked-by: Hin-Tak Leung <htl10@users.sourceforge.net>
next parent reply other threads:[~2017-12-04 22:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <734417985.2789125.1512428275673.ref@mail.yahoo.com>
2017-12-04 22:57 ` Hin-Tak Leung [this message]
2017-11-14 17:01 [PATCH] rtlwifi: rtl818x: remove redundant check for cck_power > 15 Colin King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734417985.2789125.1512428275673@mail.yahoo.com \
--to=htl10@users.sourceforge.net \
--cc=Larry.Finger@lwfinger.net \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox