Re: [PATCH wireless-next] wifi: radiotap: add definitions for the new UHR TLVs

[Johannes Berg <johannes@sipsolutions.net>]

On Wed, 2026-04-15 at 17:10 +0200, Pablo MARTIN-GOMEZ wrote:
> On 15/04/2026 16:54, Johannes Berg wrote:
> > On Wed, 2026-04-15 at 15:27 +0200, Pablo MARTIN-GOMEZ wrote:
> > > 
> > > > +	IEEE80211_RADIOTAP_UHR_ELR = 37,
> > > > +	IEEE80211_RADIOTAP_UHR = 38,
> > > Why are the values 37 and 38 but below in the doc 35 and 38?
> > 
> > The doc doesn't even exist yet as you say? Other things are being
> > assigned to 35/36.
> I wasn't clear, I didn't mean the doc like the actual documentation but
> the code comments that are used to document the defined value, e.g.
> `ieee80211_radiotap_uhr_elr - content of UHR-ELR TLV (type 35)`, it
> should be `type 37`, no?

Ah! That would be due to last minute renumbering here, indeed it should.

> Just the little brain of mine that likes when things follow expected
> patterns :) But more seriously, given that I didn't have access to the
> specs, the only thing I could use that could point out an issue was
> comparing to the patterns of existing fields and matching `known` fields
> with `data` fields.
> 

Sure, fair. I don't really remember, I do remember mostly copying from
EHT (it is necessarily similar since UHR doesn't really even define its
own MCS set etc.), and then filling in the remainder in reserved (or no
longer used) bits...

johannes