From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>,
Johannes Berg <johannes@sipsolutions.net>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jeff Johnson <jjohnson@kernel.org>
Cc: linux-wireless@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, ath12k@lists.infradead.org,
Sowmiya Sree Elavalagan <quic_ssreeela@quicinc.com>,
Saravanakumar Duraisamy <quic_saradura@quicinc.com>
Subject: Re: [PATCH ath-next v2 5/5] wifi: ath12k: Enable IPQ5424 WiFi device support
Date: Tue, 20 May 2025 09:27:57 -0700 [thread overview]
Message-ID: <748f0908-75e8-4712-86ad-220174c1672a@oss.qualcomm.com> (raw)
In-Reply-To: <20250518-ath12k-ipq5424-v2-5-ef81b833dc97@quicinc.com>
On 5/18/2025 11:22 AM, Raj Kumar Bhagat wrote:
> @@ -1008,24 +1011,19 @@ static int ath12k_ahb_probe(struct platform_device *pdev)
> if (!ab)
> return -ENOMEM;
>
> - hw_rev = (enum ath12k_hw_rev)(kernel_ulong_t)of_device_get_match_data(&pdev->dev);
> - switch (hw_rev) {
> - case ATH12K_HW_IPQ5332_HW10:
> - hif_ops = &ath12k_ahb_hif_ops_ipq5332;
> - userpd_id = ATH12K_IPQ5332_USERPD_ID;
> - break;
> - default:
> + ab_ahb = ath12k_ab_to_ahb(ab);
> + ab_ahb->ab = ab;
> + ab_ahb->ahb_data =
> + (struct ath12k_ahb_probe_data *)of_device_get_match_data(&pdev->dev);
seems like an unnecessary (and incorrect?) typecast
ahb_data is const struct ath12k_ahb_probe_data *
of_device_get_match_data() returns const void *
so the const void * => const struct ath12k_ahb_probe_data *
promotion should happen automatically, without typecasting away the const
qualifier
prev parent reply other threads:[~2025-05-20 16:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-18 18:22 [PATCH ath-next v2 0/5] wifi: ath12k: Enable IPQ5424 AHB WiFi device Raj Kumar Bhagat
2025-05-18 18:22 ` [PATCH ath-next v2 1/5] dt-bindings: net: wireless: add ath12k wifi device IPQ5424 Raj Kumar Bhagat
2025-05-20 6:14 ` Krzysztof Kozlowski
2025-05-18 18:22 ` [PATCH ath-next v2 2/5] wifi: ath12k: Add ath12k_hw_params for IPQ5424 Raj Kumar Bhagat
2025-05-20 15:59 ` Jeff Johnson
2026-03-26 5:10 ` Raj Kumar Bhagat
2025-05-18 18:22 ` [PATCH ath-next v2 3/5] wifi: ath12k: add ath12k_hw_regs " Raj Kumar Bhagat
2025-05-18 18:22 ` [PATCH ath-next v2 4/5] wifi: ath12k: Add CE remap hardware parameters " Raj Kumar Bhagat
2025-05-18 18:22 ` [PATCH ath-next v2 5/5] wifi: ath12k: Enable IPQ5424 WiFi device support Raj Kumar Bhagat
2025-05-20 16:27 ` Jeff Johnson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=748f0908-75e8-4712-86ad-220174c1672a@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jjohnson@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_rajkbhag@quicinc.com \
--cc=quic_saradura@quicinc.com \
--cc=quic_ssreeela@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox