Re: [PATCH 0/3] rtl8187: throughput fix/conf_tx callback/ack tx pkts

[Hin-Tak Leung <htl10@users.sourceforge.net>]

--- On Fri, 14/11/08, Larry Finger <Larry.Finger@lwfinger.net> wrote:
> Herton Ronaldo Krzesinski wrote:
> > Three patches that fixes/introduces the following in
> rtl8187:
> > - Fixes 8187B reported throughput issues after short
> slot handling addition.
> > - Implement conf_tx callback, instead of hardcoding
> some tx queue values.
> > - Make rate control work for 8187B sending correct
> feedback about transmitted
> >   packet status, using one of the Bulk In endpoints
> that provides this info.
> 
> With these 3 patches applied, my throughput improved again.
> Using sftp with an
> 128 MB file, my transmit rate increased to to 1.5 MB/s.
> With tcpperf, I get 9.9
> Mb/s - roughly the same.

While anecdotal, yes, I think throughput has improved. 

> 
> I'm using the 'pid' rate-control method, which
> now stabilizes at a lower stated
> rate than previously seen, but the throughput is higher.
> Curious.

The stated rate is probably how fast packets can be shipped, but the actual throughput depends on re-transmission, errors, and whether there is any stutter i.e. bursts of packets with "silences" between.

I am just happy that the driver is shaping up quite nicely. Well-done everybody :-).

Hin-Tak