Re: kunit alltests runs broken in mainline

Re: kunit alltests runs broken in mainline

[Johannes Berg]

On Mon, 2024-03-25 at 15:21 +0000, Mark Brown wrote:
> Hi,
> 
> Commit 28b3df1fe6ba2cb4 ("kunit: add wireless unit tests") which I can't
> seem to find on lore breaks full kunit runs on non-UML builds and is now
> present in mainline.  If I run:
> 
>    ./tools/testing/kunit/kunit.py run --alltests --cross_compile x86_64-linux-gnu- --arch x86_64
> 
> on a clean tree then I get:
> 
>    [15:09:20] Configuring KUnit Kernel ...
>    Generating .config ...
>    Populating config with:
>    $ make ARCH=x86_64 O=.kunit olddefconfig CROSS_COMPILE=x86_64-linux-gnu-
>    ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config.
>    This is probably due to unsatisfied dependencies.
>    Missing: CONFIG_IWLWIFI=y, CONFIG_WLAN_VENDOR_INTEL=y
> 
> UML works fine, but other real architectures (eg, arm64) seem similarly
> broken.

Hmm, strange.

> I've not looked properly yet, I'm a bit confused given that
> there's not even any dependencies for WLAN_VENDOR_INTEL and it's not
> mentoned in the defconfig.

Well it's in the directory dependencies or something I think, this seems
to help:

--- a/tools/testing/kunit/configs/all_tests.config
+++ b/tools/testing/kunit/configs/all_tests.config
@@ -28,6 +28,8 @@ CONFIG_MCTP_FLOWS=y
 CONFIG_INET=y
 CONFIG_MPTCP=y
 
+CONFIG_NETDEVICES=y
+CONFIG_WLAN=y
 CONFIG_CFG80211=y
 CONFIG_MAC80211=y
 CONFIG_WLAN_VENDOR_INTEL=y


But I'm not sure why ARCH=um is different?

johannes

Re: kunit alltests runs broken in mainline

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

On Mon, Mar 25, 2024 at 04:29:53PM +0100, Johannes Berg wrote:

> But I'm not sure why ARCH=um is different?

It's probably something to do with it lacking a bunch of features of
normal architectures, especially around hardware support.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: kunit alltests runs broken in mainline

[Johannes Berg]

On Mon, 2024-03-25 at 15:55 +0000, Mark Brown wrote:
> On Mon, Mar 25, 2024 at 04:29:53PM +0100, Johannes Berg wrote:
> 
> > But I'm not sure why ARCH=um is different?
> 
> It's probably something to do with it lacking a bunch of features of
> normal architectures, especially around hardware support.

Feels though that should make it *more* likely to not have support for
some hardware driver like iwlwifi, not *less* :-)

Anyway, does it fix it for you as well? if yes, where/how should we get
that in?

johannes

Re: kunit alltests runs broken in mainline

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

On Mon, Mar 25, 2024 at 05:16:35PM +0100, Johannes Berg wrote:

> Anyway, does it fix it for you as well? if yes, where/how should we get
> that in?

Seems to.  Given the breakage I'd expect it to go to Linus urgently, I
don't know that it super matters exactly how but I guess net will be
sending a pull anyway and is the source of the breakage?  

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: kunit alltests runs broken in mainline

[Johannes Berg]

On Mon, 2024-03-25 at 16:23 +0000, Mark Brown wrote:
> On Mon, Mar 25, 2024 at 05:16:35PM +0100, Johannes Berg wrote:
> 
> > Anyway, does it fix it for you as well? if yes, where/how should we get
> > that in?
> 
> Seems to.  Given the breakage I'd expect it to go to Linus urgently, I
> don't know that it super matters exactly how but I guess net will be
> sending a pull anyway and is the source of the breakage?  

Hmm, yeah ... after the previous discussion I had just put the patch in
there directly in wireless, so I'll just add this fix too.

johannes