From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,INCLUDES_PULL_REQUEST,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4258BC433DB for ; Sat, 23 Jan 2021 21:33:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 00F0B22BEA for ; Sat, 23 Jan 2021 21:33:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726223AbhAWVdO (ORCPT ); Sat, 23 Jan 2021 16:33:14 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:22588 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725943AbhAWVdN (ORCPT ); Sat, 23 Jan 2021 16:33:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611437506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WvOaj8hv0KE32bVTxypzvxrVf11BMqlkb446o+mx/s0=; b=OB0EoJS50K+9s9Pv/Kzm7tQvBGz4ZlMNK8FtmFmAyI+fqc3ZOeD1dZR65o9DIQ1jBd2B/v /7onuNUR1//yAtfbKGRTd+OslgsgqG1urMtCTjSRwcQV+CSE0mJoL3Q4gJunyN2A9qXfEM Dy2IP+iXTQyRjCHfQADMjyeW3Bp3JYI= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-349-sgWGPFm0PqGCl-qa4sh-1w-1; Sat, 23 Jan 2021 16:31:44 -0500 X-MC-Unique: sgWGPFm0PqGCl-qa4sh-1w-1 Received: by mail-ed1-f72.google.com with SMTP id w4so5014999edu.0 for ; Sat, 23 Jan 2021 13:31:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WvOaj8hv0KE32bVTxypzvxrVf11BMqlkb446o+mx/s0=; b=sguAI5ej9+FofydLaU10vQ1LGyIiOB7DWBaOKBnq5F8kP9AbpWyVAWDdsS3M1Le3lF ZchfndF07fDf47mrZUfUl4oWNZGmnnTqWHw5O7WPAx+U8MOUfIoG5ciK8Q3x6gQ6gfI2 sl1QM74YMusQVXWttvpt5NsgwREyJSYjzGbHM/4e7F4iPH9/dop1nqQJ+E55v8ClM9dU 8pif2qoDfWvZ4nL5PSsp74moPbK6SDmq6Ol/8q6lf9M3+/Kjis6A9/OLRURk7byjcber qKHDhE0oOKniCWhFEKNB5OyqTh0FpJBFmVFgBrPz69900NMdHlAgjC4gVk9IDb4RyRl/ Qqcw== X-Gm-Message-State: AOAM533m1wmEjggA1fJ1vkXtgcoOSs2Opy6V3YQsFB/oLljsMVyNrk/o xNj1v76Rns9dT5bWSI0MRxuVUqkWbfQlP2U9VJRVlj1glDkF7hHtKispyO1l1KgQTrGhhLwucuy Nlasm/IHNC2Xkl30y4ijRlQm5e17lZ50Ojo6sGqAC0o7BpaNbvYeyAP8MS19YHT58PjfxVIz/vA MgX0Y= X-Received: by 2002:a05:6402:1655:: with SMTP id s21mr7871483edx.360.1611437502855; Sat, 23 Jan 2021 13:31:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJxTtcO7wYhsvRpjs3RnOtimCoehr2ES4ctqHG7peNecCWcQvyrp4NROH9HDnT0itXz4n4tyHg== X-Received: by 2002:a05:6402:1655:: with SMTP id s21mr7871470edx.360.1611437502624; Sat, 23 Jan 2021 13:31:42 -0800 (PST) Received: from x1.localdomain (2001-1c00-0c1e-bf00-37a3-353b-be90-1238.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:37a3:353b:be90:1238]) by smtp.gmail.com with ESMTPSA id q2sm7588078edv.93.2021.01.23.13.31.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Jan 2021 13:31:42 -0800 (PST) Subject: Re: pull-request: mac80211 2021-01-18.2 To: Johannes Berg , netdev@vger.kernel.org Cc: linux-wireless@vger.kernel.org References: <20210118204750.7243-1-johannes@sipsolutions.net> From: Hans de Goede Message-ID: <77c606d4-a78a-1fa3-5937-b270c3d0bbd3@redhat.com> Date: Sat, 23 Jan 2021 22:31:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210118204750.7243-1-johannes@sipsolutions.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 1/18/21 9:47 PM, Johannes Berg wrote: > Hi, > > New try, dropped the 160 MHz CSA patch for now that has the sparse > issue since people are waiting for the kernel-doc fixes. > > Please pull and let me know if there's any problem. > > Thanks, > johannes > > > > The following changes since commit 220efcf9caf755bdf92892afd37484cb6859e0d2: > > Merge tag 'mlx5-fixes-2021-01-07' of git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux (2021-01-07 19:13:30 -0800) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git tags/mac80211-for-net-2021-01-18.2 > > for you to fetch changes up to c13cf5c159660451c8fbdc37efb998b198e1d305: > > mac80211: check if atf has been disabled in __ieee80211_schedule_txq (2021-01-14 22:27:38 +0100) > > ---------------------------------------------------------------- > Various fixes: > * kernel-doc parsing fixes > * incorrect debugfs string checks > * locking fix in regulatory > * some encryption-related fixes > > ---------------------------------------------------------------- > Felix Fietkau (3): > mac80211: fix fast-rx encryption check > mac80211: fix encryption key selection for 802.3 xmit > mac80211: do not drop tx nulldata packets on encrypted links > > Ilan Peer (1): > cfg80211: Save the regulatory domain with a lock So I'm afraid that I have some bad news about this patch, it fixes the RCU warning which I reported: https://lore.kernel.org/linux-wireless/20210104170713.66956-1-hdegoede@redhat.com/ But it introduces a deadlock. See: https://lore.kernel.org/linux-wireless/d839ab62-e4bc-56f0-d861-f172bf19c4b3@redhat.com/ for details. Note we really should fix this new deadlock before 5.11 is released. This is worse then the RCU warning which this patch fixes. Regards, Hans > > Johannes Berg (1): > cfg80211/mac80211: fix kernel-doc for SAR APIs > > Lorenzo Bianconi (1): > mac80211: check if atf has been disabled in __ieee80211_schedule_txq > > Mauro Carvalho Chehab (1): > cfg80211: fix a kerneldoc markup > > Shayne Chen (1): > mac80211: fix incorrect strlen of .write in debugfs > > include/net/cfg80211.h | 5 ++++- > include/net/mac80211.h | 1 + > net/mac80211/debugfs.c | 44 ++++++++++++++++++++------------------------ > net/mac80211/rx.c | 2 ++ > net/mac80211/tx.c | 31 +++++++++++++++++-------------- > net/wireless/reg.c | 11 ++++++++++- > 6 files changed, 54 insertions(+), 40 deletions(-) > >