Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Zhiling Zou <zhilinz@nebusec.ai>, linux-wireless@vger.kernel.org
Cc: gregory.greenman@intel.com, miriam.rachel.korenblit@intel.com,
	 vega@nebusec.ai
Subject: Re: [PATCH wireless 0/1] wifi: mac80211: reset default-key debugfs after netdev recreate
Date: Mon, 07 Sep 2026 16:59:41 +0200	[thread overview]
Message-ID: <78ae8d5339fb26ec79f11661e68c02ad5c36dce2.camel@sipsolutions.net> (raw)
In-Reply-To: <cover.1788783312.git.zhilinz@nebusec.ai> (sfid-20260907_142729_116498_9C6A08A7)

On Mon, 2026-09-07 at 20:27 +0800, Zhiling Zou wrote:
> Hi Linux kernel maintainers,
> 
> We found and validated an issue in net/mac80211/debugfs_key.c and
> net/mac80211/debugfs_netdev.c. The bug is reachable by a root user.
> 
> We've tested it, and it should not affect any other functionality.
> 
> We will provide detailed information about the bug in this email, along
> with a PoC to trigger it.

[snip]

Did you read what your LLM wrote?


>     	printf("[4/7] add WEP40 group key idx 0\n");
>     	err = new_key(sock, family_id, ifindex, 0, wep40_key, sizeof(wep40_key));
>     	if (err < 0) {
>     		fprintf(stderr, "NL80211_CMD_NEW_KEY failed: %s (%d)\n",
>     			nl_geterror(err), err);
>     		return 1;
>     	}
>     
>     	printf("[5/7] set key idx 0 as the default key on the deflink\n");
>     	err = set_default_key(sock, family_id, ifindex, 0, -1);
>     	if (err < 0) {
>     		fprintf(stderr, "initial NL80211_CMD_SET_KEY failed: %s (%d)\n",
>     			nl_geterror(err), err);
>     		return 1;
>     	}
>     
>     	printf("[6/7] add MLO link 1; this recreates the netdev debugfs tree while the key stays alive\n");

Sure, WEP on MLO, but somehow debugfs is the problem ...

johannes

      parent reply	other threads:[~2026-09-07 14:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-07 12:27 [PATCH wireless 0/1] wifi: mac80211: reset default-key debugfs after netdev recreate Zhiling Zou
2026-09-07 12:27 ` [PATCH wireless 1/1] " Zhiling Zou
2026-09-07 14:59 ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78ae8d5339fb26ec79f11661e68c02ad5c36dce2.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=gregory.greenman@intel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=miriam.rachel.korenblit@intel.com \
    --cc=vega@nebusec.ai \
    --cc=zhilinz@nebusec.ai \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox