Linux wireless drivers development
 help / color / mirror / Atom feed
From: Ruslan Isaev <legale.legale@gmail.com>
To: linux-wireless@vger.kernel.org
Cc: Felix Fietkau <nbd@nbd.name>,
	Lorenzo Bianconi <lorenzo@kernel.org>,
	Ryder Lee <ryder.lee@mediatek.com>,
	Shayne Chen <shayne.chen@mediatek.com>,
	Sean Wang <sean.wang@mediatek.com>
Subject: Re: [PATCH] wifi: mt76: disable rx napi before queue cleanup
Date: Mon, 18 May 2026 01:46:19 +0300	[thread overview]
Message-ID: <79943c87-b920-4ef8-a471-61b03792e097@gmail.Com> (raw)
In-Reply-To: <agEbiurBZzZv_Yt0@wico-dev.wnam.ru>

Gentle ping for review

May 11, 2026 02:58:02 Ruslan Isaev <legale.legale@gmail.com>:

> mt76_dma_cleanup() already disables tx napi before deleting it, but
> it still removes rx napi instances while they can remain enabled on the
> normal device remove path. On mt7915 this triggers a warning.
> 
> Disable each rx napi instance before netif_napi_del() and page pool
> destruction. This fixes repeated warnings on rmmod mt7915e on
> mt7915e/mt7981b.
> 
> Signed-off-by: Ruslan Isaev <legale.legale@gmail.com>
> ---
> drivers/net/wireless/mediatek/mt76/dma.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/dma.c b/drivers/net/wireless/mediatek/mt76/dma.c
> index f8c2fe5f2..12183142f 100644
> --- a/drivers/net/wireless/mediatek/mt76/dma.c
> +++ b/drivers/net/wireless/mediatek/mt76/dma.c
> @@ -1189,6 +1189,7 @@ void mt76_dma_cleanup(struct mt76_dev *dev)
>     mt76_for_each_q_rx(dev, i) {
>         struct mt76_queue *q = &dev->q_rx[i];
> 
> +       napi_disable(&dev->napi[i]);
>         netif_napi_del(&dev->napi[i]);
>         mt76_dma_rx_cleanup(dev, q);
> 
> -- 
> 2.39.5

  reply	other threads:[~2026-05-17 22:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-10 23:58 [PATCH] wifi: mt76: disable rx napi before queue cleanup Ruslan Isaev
2026-05-17 22:46 ` Ruslan Isaev [this message]
2026-05-22 21:42   ` Sean Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79943c87-b920-4ef8-a471-61b03792e097@gmail.Com \
    --to=legale.legale@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=nbd@nbd.name \
    --cc=ryder.lee@mediatek.com \
    --cc=sean.wang@mediatek.com \
    --cc=shayne.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox