From: dasaris@codeaurora.org
To: "Otcheretianski, Andrei" <andrei.otcheretianski@intel.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] cfg80211: Authentication offload to user space in AP mode
Date: Thu, 20 Dec 2018 16:37:31 +0530 [thread overview]
Message-ID: <7bfaa41538350a2b385b14b00bb0444e@codeaurora.org> (raw)
In-Reply-To: <B2CD83211F5FDD478D7EFFF030D107EDCD031EAB@HASMSX111.ger.corp.intel.com>
On 2018-12-18 19:10, Otcheretianski, Andrei wrote:
>> So, interesting - Andrei also added the PMKID but also the PMK here,
>> in a
>> separate patch:
>> https://patchwork.kernel.org/patch/10732093/
>
> Yeah, PMK is needed for the devices that offload 4way handshake.
Thanks. Fine with us too. Will have an updated patchset with the pmkid
part removed, as this is already added with the patch by Andrei.
>>> [...]
>> > - if (!info->attrs[NL80211_ATTR_SSID])
>> > + if (!info->attrs[NL80211_ATTR_SSID] &&
>> > + dev->ieee80211_ptr->iftype != NL80211_IFTYPE_AP &&
>> > + dev->ieee80211_ptr->iftype != NL80211_IFTYPE_AP_VLAN &&
>> > + dev->ieee80211_ptr->iftype != NL80211_IFTYPE_P2P_GO)
>> > return -EINVAL;
>>
>> Hm. do we really expect this on AP_VLAN?
>
> Actually I'm not sure about GO neither. P2P doesn't use SAE etc..
>
> Andrei
Since these vifs are similar to an AP, we have considered external
authentication to be applicable for them as well. Please let me know if
this is fine . I shall update the patch accordingly.
>>
>> johannes
Thanks,
Srinivas
next prev parent reply other threads:[~2018-12-20 11:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 9:31 [PATCH] cfg80211: Authentication offload to user space in AP mode Srinivas Dasari
2018-12-18 13:28 ` Johannes Berg
2018-12-18 13:40 ` Otcheretianski, Andrei
2018-12-20 11:07 ` dasaris [this message]
2019-01-15 13:26 ` Johannes Berg
2019-01-23 12:28 ` dasaris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bfaa41538350a2b385b14b00bb0444e@codeaurora.org \
--to=dasaris@codeaurora.org \
--cc=andrei.otcheretianski@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).