RE: [PATCH v2 3/6] iw: util: support parsing link id

[Zong-Zhe Yang <kevin_yang@realtek.com>]

Johannes Berg <johannes@sipsolutions.net> wrote:
> On Wed, 2025-09-17 at 13:55 +0800, Zong-Zhe Yang wrote:
> > For NL80211_FLAG_MLO_VALID_LINK_ID cases, MLD needs to assign link id,
> > but non-MLD doesn't. Add support of parsing link id where the pattern
> > is as below.
> >
> >       [link-id <LINK ID>]
> >
> > If found, put NL80211_ATTR_MLO_LINK_ID and remove the assignment from
> > the argv range.
> >
> > +     memmove(argv + pos, argv + pos + 2,
> > +             sizeof(*argv) * (*argc - pos - 2));
> 
> Honestly, I don't really like this, it's a bit too magic? What if you have something in there that
> is like
> 
>  ... ssid link-id foo bar
> 
> and then it *meant* the SSID to be "link-id", but with this it now actually fails or so? I don't
> think it's a good idea.

I missed to consider this kind of cases, sorry.

> 
> So I think it should just be parsing it where it is at the beginning, and then for the last patch
> just put it at the beginning in the help, call parse_link_id() first like you did already, and we
> don't get any such potential mixups?
> 

Thanks. I think it works.
I will send v3, which turns to parse link-id field at the beginning of argv.