Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: Per MLO link TX stats
Date: Tue, 27 Aug 2024 17:56:53 +0200	[thread overview]
Message-ID: <7ccb9c8ccb0dd16539ac064a35d6bf6b31d0bf0d.camel@sipsolutions.net> (raw)
In-Reply-To: <c896c0d6-b43f-ba6d-336a-eca15c60529f@candelatech.com>

On Fri, 2024-07-12 at 10:52 -0700, Ben Greear wrote:
> Hello,
> 
> I've been trying to get better per MLO link stats.  I see that the rx path
> stats are there, but in the tx path, I do not see anything other than 'deflink'
> getting updated.

Yeah, nobody really cared too much about statistics yet. I know. Sorry.
Not much time to work on it either now.

> And, at least with iwlwifi, I cannot find any way to actually see what link-id
> was used to transmit a frame in the tx status callbacks (or anywhere else I looked).

You can probably derive that from the band for iwlwifi, since it only
supports one active link on each 2.4 / 5 / 6 GHz if at all. And the band
I guess you'd get from the LMAC ID or something. Should be in there
somewhere... IOW, I think it's possible, but I'm also not entirely sure
how we'd do it.

> In the case where there is a single active link, then I can hack something together
> that should be at least mostly right, but that won't fix any future radio that can
> do 2+ active links.
> 
> Any suggestions for best path forward on this?

I really think we also need to do some work on the API/cfg80211 level,
and have link station statistics in cfg80211 instead of full station,
and then combine them to (older) userspace in cfg80211, i.e. if
userspace doesn't request broken out per-link statistics. There's
probably a bunch of work here, and I only have a vague idea of how it
should be done...

  reply	other threads:[~2024-08-27 15:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-12 17:52 Per MLO link TX stats Ben Greear
2024-08-27 15:56 ` Johannes Berg [this message]
2024-08-27 16:12   ` Ben Greear
2024-08-27 16:20     ` Johannes Berg
2024-08-27 16:28       ` Ben Greear
2024-08-27 16:41         ` Johannes Berg
2024-08-27 18:17           ` Ben Greear
2024-08-28 12:50             ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ccb9c8ccb0dd16539ac064a35d6bf6b31d0bf0d.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox