From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F72A36896A for ; Thu, 26 Feb 2026 17:09:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=168.119.38.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772125800; cv=none; b=b5EaKnbjEgwS2xzdbBA+huEAxFDIlouBncGXGW3mmXQTYx7QHQBl2sg7HSizB3h6cfAWnoAYHcoHwZLncjtMhFnGpugGdrWYjWAQJ0FoQCovfUx5oixH/VsP2b2DunKBIT189ZNM0PmEFsamwwMyMkkYmXd8sPNYzd6V5Ien83I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772125800; c=relaxed/simple; bh=T/16ZUcKDAmOYFFJDS0ESrijk/ysXwmsI+JU0hSpiII=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=L7r6HyHVmJ295lXjSAamNeSp6Rh6/owQFuWyZHetBn+O1A/2SyNLXIxbnwTagr1rhDuorB7BOrMFjL3G8HRBluoymAQDFTFOIuFL6C5t7/uytTDIcZADcAzft+zouwLmEkqpcCSlrMsQWWPcXLM6kTcWRKFw6Fmv6eZQvcGcdRM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net; spf=pass smtp.mailfrom=sipsolutions.net; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b=BRmB5w6Z; arc=none smtp.client-ip=168.119.38.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b="BRmB5w6Z" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=D6/9iK5hF7SwnfdYRzNGKgaFFGeGSovd9eT1g8UuAm0=; t=1772125799; x=1773335399; b=BRmB5w6Z+1Y76iXb53Su5mznAoiWMmcSC89uc87pXPpYv3E WRRhPiqCRZ4vGz5EcpslXxbVG3jq2dB87WABq79rNGwleZCKmvKn1dhCdnmWZgxPF/BnDp5azKDU7 Ao6Q639SxoTC40CdTVsLd8P6FqfPaHSL98OPU4uCfBTWoatbx5X0lv4/WfwOpMRfE/dqSVK7T6cd/ Sr9F9+t/Ki2uCCLhXnJhfA60KOmkurHgpTluzaTy73axAaKdOCqzag/b006SEmhQRaLg4/8d+ZC9S CbU4CV4y9yvdfWrFtXI/v9P48XXT4EqbkZgULP7Epge2knJ3eqNT3W/jZ4m0v7Zg==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.98.2) (envelope-from ) id 1vves1-00000002VLf-1YoP; Thu, 26 Feb 2026 18:09:49 +0100 Message-ID: <7fa9af36361bea13b0aab325687486c990c666df.camel@sipsolutions.net> Subject: Re: [PATCH wireless-next 3/3] wifi: mac80211_hwsim: Advertise support for IEEE 802.1X authentication protocol From: Johannes Berg To: Kavita Kavita Cc: linux-wireless@vger.kernel.org Date: Thu, 26 Feb 2026 18:09:48 +0100 In-Reply-To: <67e9955a-1287-4467-9b52-be89144effbc@oss.qualcomm.com> References: <20260226065442.4182232-1-kavita.kavita@oss.qualcomm.com> <20260226065442.4182232-4-kavita.kavita@oss.qualcomm.com> <3ecb3d440ed3ab4fe4cd3765e0c8457ef58fd6b6.camel@sipsolutions.net> <15cd54d4-a663-423b-b4c5-9a058f5bc73d@oss.qualcomm.com> <916b0969c559f1faeba94bdef792da646b9b0c21.camel@sipsolutions.net> <67e9955a-1287-4467-9b52-be89144effbc@oss.qualcomm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-malware-bazaar: not-scanned On Thu, 2026-02-26 at 22:28 +0530, Kavita Kavita wrote: >=20 > On 2/26/2026 10:20 PM, Johannes Berg wrote: > > On Thu, 2026-02-26 at 22:19 +0530, Kavita Kavita wrote: > > >=20 > > > Sorry, I missed one case earlier. EPPKE mandates (Re)Association fram= e > > > encryption support, so we should only advertise EPPKE when the driver= indicates > > > support for (Re)Association frame encryption in mac80211. > >=20 > > Oh, OK, but we could also check that in mac80211, in register_hw(), I > > think? >=20 > For EPPKE, I will handle it like this: >=20 > @@ -1598,6 +1598,15 @@ int ieee80211_register_hw(struct ieee80211_hw *hw) > local->sband_allocated |=3D BIT(band); > } > =20 > + /* > + * mac80211 supports EPPKE, if the driver supports (Re)Associatio= n > + * frame encryption > + */ > + if (wiphy_ext_feature_isset(local->hw.wiphy, > + NL80211_EXT_FEATURE_ASSOC_FRAME_ENCRY= PTION)) > + wiphy_ext_feature_set(local->hw.wiphy, > + NL80211_EXT_FEATURE_EPPKE); >=20 > For IEEE 802.1X Authentication, I am thinking to advertise its support di= rectly > from mac80211, in ieee80211_alloc_hw_nm, without checking for (Re)Associa= tion encryption > support from the driver. >=20 Both Makes sense, thanks! johannes