From: Andreas Tobler <andreas.tobler@onway.ch>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: regression: [PATCH] wifi: mac80211: set station RX-NSS on reconfig
Date: Fri, 8 Mar 2024 15:13:00 +0100 [thread overview]
Message-ID: <81fda000-4562-431d-ad47-7fdec469b0dc@onway.ch> (raw)
In-Reply-To: <29f7aa2c233277ab4bb56bcff8e228036ee96a2e.camel@sipsolutions.net>
[-- Attachment #1: Type: text/plain, Size: 1092 bytes --]
On 08.03.2024 13:19, Johannes Berg wrote:
> On Fri, 2024-03-08 at 12:58 +0100, Andreas Tobler wrote:
>> Hello Johannes, all.
>>
>> with this commit[0] we encounter a performance regression in one of our
>> AP/STA tests. The performance drop is about 100Mbps+
>>
>> Our setup is a hostap (2.10) configured AP on 802.11ac, channel 46.
>> (40MHz). The client connects via wpa (2.10) and then we produce traffic.
>> Before this commit, the throughput was around 250 Mbps, with this commit
>> the performance is now down to 135 Mbps.
>>
>> The wifi cards we use are WLE600VX from compex, a ath10k based one. The
>> kernel we're on is 6.1.80. We've seen it on 6.6 too but didn't investigate.
>>
>> Now, the ieee80211_sta_set_rx_nss() function has two FIXME comments. One
>> in where it handles the ht capability and one in the vht part. Both
>> FIXME's are: 'consider rx_highest?'
>>
>
> I think you'll find that all that is unrelated, and this fixes it:
[link dropped since outlook garbles it completely]
Amazing! I can confirm that my performance drop has gone.
Thank you very much!
Andreas
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4763 bytes --]
prev parent reply other threads:[~2024-03-08 14:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <014a25e4-5609-4e3e-a593-8a2bf1bd5568@onway.ch>
2024-03-08 12:19 ` regression: [PATCH] wifi: mac80211: set station RX-NSS on reconfig Johannes Berg
2024-03-08 14:13 ` Andreas Tobler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81fda000-4562-431d-ad47-7fdec469b0dc@onway.ch \
--to=andreas.tobler@onway.ch \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox