From: "Reizer, Eyal" <eyalr@ti.com>
To: Tony Lindgren <tony@atomide.com>, Eyal Reizer <eyalreizer@gmail.com>
Cc: "kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"Nori, Sekhar" <nsekhar@ti.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [EXTERNAL] Re: [PATCH] wlcore: sdio: check for valid platform device data before suspend
Date: Mon, 28 May 2018 08:20:00 +0000 [thread overview]
Message-ID: <825adbcb92cf4b6980a4029db7fdd863@ti.com> (raw)
In-Reply-To: <20180524142440.GY77025@atomide.com>
> > the wl pointer can be null In case only wlcore_sdio is probed while
> > no WiLink module is successfully probed, as in the case of mounting a
> > wl12xx module while using a device tree file configured with wl18xx
> > related settings.
> > In this case the system was crashing in wl1271_suspend() as platform
> > device data is not set.
> > Make sure wl the pointer is valid before using it.
>=20
> Just checking.. It seems like this fix is separate from the PM
> runtime conversion, right?
Correct. This is a separate patch/
>=20
> > Signed-off-by: Eyal Reizer <eyalr@ti.com>mamai
>=20
> Looks like you have some extra characters ^^^^^ here.
>=20
Thanks!. Will fix and submit v2
Best Regards,
Eyal
prev parent reply other threads:[~2018-05-28 8:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 11:35 [PATCH] wlcore: sdio: check for valid platform device data before suspend Eyal Reizer
2018-05-24 14:24 ` Tony Lindgren
2018-05-28 8:20 ` Reizer, Eyal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=825adbcb92cf4b6980a4029db7fdd863@ti.com \
--to=eyalr@ti.com \
--cc=eyalreizer@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).