From: Ping-Ke Shih <pkshih@realtek.com>
To: Roopni Devanathan <quic_rdevanat@quicinc.com>,
"ath12k@lists.infradead.org" <ath12k@lists.infradead.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Pradeep Kumar Chitrapu <quic_pradeepc@quicinc.com>
Subject: RE: [PATCH ath-next v3] wifi: ath12k: Fix incorrect rates sent to firmware
Date: Fri, 21 Mar 2025 00:28:32 +0000 [thread overview]
Message-ID: <8399ca6fa2f34898a86d07d822a09a5d@realtek.com> (raw)
In-Reply-To: <20250320112426.1956961-1-quic_rdevanat@quicinc.com>
Roopni Devanathan <quic_rdevanat@quicinc.com> wrote:
> From: Pradeep Kumar Chitrapu <quic_pradeepc@quicinc.com>
>
> Before firmware assert, if there is a station interface in the device
> which is not associated with an AP, the basic rates are set to zero.
> Following this, during firmware recovery, when basic rates are zero,
> ath12k driver is sending invalid rate codes, which are negative values,
> to firmware. This results in firmware assert.
>
> Fix this by checking if rate codes are valid, before sending them
> to the firmware.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.4.1-00199-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Pradeep Kumar Chitrapu <quic_pradeepc@quicinc.com>
> Signed-off-by: Roopni Devanathan <quic_rdevanat@quicinc.com>
For the __ffs() part,
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
next prev parent reply other threads:[~2025-03-21 0:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 11:24 [PATCH ath-next v3] wifi: ath12k: Fix incorrect rates sent to firmware Roopni Devanathan
2025-03-21 0:28 ` Ping-Ke Shih [this message]
2025-03-21 4:02 ` Vasanthakumar Thiagarajan
2025-04-07 15:23 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8399ca6fa2f34898a86d07d822a09a5d@realtek.com \
--to=pkshih@realtek.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_pradeepc@quicinc.com \
--cc=quic_rdevanat@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox