Re: [PATCH] mac80211 : fix a race with update_tkip_key

Johannes Berg
2009-06-21T09:21:22Z

[-- Attachment #1: Type: text/plain, Size: 586 bytes --]

On Fri, 2009-06-19 at 21:37 +0200, gregor kowski wrote:
> Update : I changed the logic. There is a single flag per key, tracking
> if we send the key instead of a flag per rx queue.
>
> The mac80211 tkip code won't call update_tkip_key, if some rx packets
> get received without KEY_FLAG_UPLOADED_TO_HARDWARE. This can happen on
> first packet because the hardware key stuff is called asynchronously with
> todo workqueue.
>
> This patch workaround that by tracking if we send the key to hardware.

What was wrong with using an enum, in the existing variable?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]