Re: [PATCH] mac80211 : fix a race with update_tkip_key

Johannes Berg
2009-06-09T17:52:35Z

[-- Attachment #1: Type: text/plain, Size: 747 bytes --]

On Tue, 2009-06-09 at 19:48 +0200, gregor kowski wrote:

> > Right. But drivers are free to even only _encrypt_ tkip frames and never
> > _decrypt_ them after having accepted a hardware key, iow that is
> > perfectly valid behaviour and I don't think we should keep uploading the
> > key to the driver. Worst case is that the proper upload fails and we
> > decrypt all frames in software until the next rollover.
> >
> What's the point of setting the tkip callback if we aren't interested
> in decrypting data by hardware ?

Might depend on something else? Anyhow I don't see the point of
continuing to call the callback. Maybe it should just be part of the key
todo instead when the key is initially uploaded to the hw.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]