Re: [PATCH] mac80211 : fix a race with update_tkip_key

gregor kowski
2009-11-07T18:10:01Z

Hi,

sorry for the long delay.

On Sat, Aug 22, 2009 at 8:45 AM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Sat, 2009-08-22 at 00:13 +0200, gregor kowski wrote:
>
>> +enum ieee80211_internal_tkip_initialized {
>> +     TKIP_INITIALIZED_NONE,
>> +     TKIP_INITIALIZED_PHASE1,
>> +     TKIP_INITIALIZED_UPDATE_KEY,
>> +};
>
> Those constants and the enum itself really need better names. This way,
> there's no way to understand what it means without reading all the code.
>
Could you suggest better name ?

ieee80211_internal_tkip_state and
TKIP_STATE_NOT_INIT
TKIP_STATE_PHASE1_DONE
TKIP_STATE_PHASE1_HW_UPLOADED
?

Thanks

Gregor