From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>
Cc: johannes.berg@intel.com, chi-hsien.lin@infineon.com,
chung-hsien.hsu@infineon.com, linux-wireless@vger.kernel.org,
brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com,
linux-kernel@vger.kernel.org, kees@kernel.org
Subject: Re: [PATCH] brcmfmac: validate bsscfg indices in IF events
Date: Sat, 28 Mar 2026 20:32:48 +0100 [thread overview]
Message-ID: <83c07d92-ca7e-4569-9358-bda3bd774a22@broadcom.com> (raw)
In-Reply-To: <20260323074551.93530-1-pengpeng@iscas.ac.cn>
On 23/03/2026 08:45, Pengpeng Hou wrote:
> brcmf_fweh_handle_if_event() validates the firmware-provided interface
> index before it touches drvr->iflist[], but it still uses the raw
> bsscfgidx field as an array index without a matching range check.
>
> Reject IF events whose bsscfg index does not fit in drvr->iflist[]
> before indexing the interface array.
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c | 5 +++++
> 1 file changed, 5 insertions(+)
prev parent reply other threads:[~2026-03-28 19:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 7:45 [PATCH] brcmfmac: validate bsscfg indices in IF events Pengpeng Hou
2026-03-28 19:32 ` Arend van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83c07d92-ca7e-4569-9358-bda3bd774a22@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=chi-hsien.lin@infineon.com \
--cc=chung-hsien.hsu@infineon.com \
--cc=johannes.berg@intel.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pengpeng@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox