From: Sven Eckelmann <sven.eckelmann@openmesh.com>
To: pradeepc@codeaurora.org
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k:add support for multicast rate control
Date: Tue, 17 Apr 2018 08:33:12 +0200 [thread overview]
Message-ID: <8422067.oV49EfR4qE@bentobox> (raw)
In-Reply-To: <fe1af65b1042bc3c2b551dcbe7d53f3c@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 1416 bytes --]
On Montag, 16. April 2018 22:10:50 CEST pradeepc@codeaurora.org wrote:
[...]
> > I see two major problems here without checking the actual
> > implementation
> > details:
> >
> > * hw_value is incorrect for a couple of devices. Some devices use a
> > different
> > mapping when they receive rates inforamtion (hw_value) then the ones
> > you use
> > for the mcast/bcast/beacon rate setting. I've handled in my POC patch
> > like
[...]
> Isn't this already fixed in https://patchwork.kernel.org/patch/9150145/
> ?
No, this is exactly the patch which causes the problem for you. The parameter
for these settings stayed the same but this patch changes the order in
ieee80211_rate to make it easier for the driver to parse the (reordered) rx
status information for CCK rates (maybe also tx - not sure about that right
now).
> > * bcast + mcast (+ mgmt) have to be set separately
>
> Can you please let me know why this would be necessary?
> Although I see minstrel rate control is currently seems using the
> mcast_rate
> setting to set MGMT/BCAST/MCAST rates, will this not be misleading to
> user
> passed value with 'iw set mcast_rate' for MGMT traffic as well?
What about broadcast? MGMT was only mentioned here because it is the third
item which can be manipulated the same way. But yes, it would be good to get
the mgmt rates in sync with the non-hw-rate-control drivers.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-04-17 6:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 5:10 [PATCH] ath10k:add support for multicast rate control pradeepc
2018-04-17 6:33 ` Sven Eckelmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-04-12 4:04 Pradeep Kumar Chitrapu
2018-04-12 8:00 ` Sven Eckelmann
2020-12-21 17:23 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8422067.oV49EfR4qE@bentobox \
--to=sven.eckelmann@openmesh.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pradeepc@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).