From: Paul Fox <pgf@laptop.org>
To: Amitkumar Karwar <akarwar@marvell.com>
Cc: linux-wireless@vger.kernel.org, libertas-dev@lists.infradead.org
Subject: Re: [PATCH] Added support for host sleep feature
Date: Thu, 08 Jul 2010 11:11:32 -0400 [thread overview]
Message-ID: <8674.1278601892@foxharp.boston.ma.us> (raw)
In-Reply-To: <1278551628.3339.7.camel@localhost.localdomain> (sfid-20100708_024419_276276_7B25A76B)
amitkumar wrote:
> From: Amitkumar Karwar <akarwar@marvell.com>
>
> Existing "ethtool -s ethX wol X" command configures hostsleep
> parameters, but those are activated only during suspend/resume,
> there is no way to configure host sleep without actual suspend.
as background, can you expand on how this is useful? i just spent
a bunch of time debugging issues with HOST_SLEEP_CFG and
HOST_SLEEP_ACTIVATE (which doesn't work on an 8388) on the XO-1
OLPC laptop, and i'm wondering whether or how this would have
helped.
as an aside, since i know you've helped OLPC with some of these
issues in the past, the pertinent results of my debugging are:
http://dev.laptop.org/git/olpc-2.6/commit/?h=olpc-2.6.31&id=515dc7313c37218fa02888eb19fba065ca0ab63c
and
http://dev.laptop.org/git/olpc-2.6/commit/?h=olpc-2.6.31&id=8db05fd8301980cf48ff10f61c977256e1f136b5
other nearby commits, all dated 6/22/2010, are related, but were
less central to the problems we were having.)
paul
>
> This patch adds debugfs command to enable/disable host sleep based on
> already configured host sleep parameters using wol command.
>
> Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
> Signed-off-by: Kiran Divekar <dkiran@marvell.com>
> ---
> drivers/net/wireless/libertas/README | 12 ++++++
> drivers/net/wireless/libertas/cmd.c | 61 ++++++++++++++++++++++++++++-
> drivers/net/wireless/libertas/cmd.h | 2 +
> drivers/net/wireless/libertas/debugfs.c | 66 +++++++++++++++++++++++++++++++
> drivers/net/wireless/libertas/main.c | 34 +---------------
> 5 files changed, 142 insertions(+), 33 deletions(-)
>
....
=---------------------
paul fox, pgf@laptop.org
next prev parent reply other threads:[~2010-07-08 15:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 1:13 [PATCH] Added support for host sleep feature Amitkumar Karwar
2010-07-08 15:11 ` Paul Fox [this message]
2010-07-09 13:01 ` Amitkumar Karwar
2010-07-13 8:33 ` Alberto Panizzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8674.1278601892@foxharp.boston.ma.us \
--to=pgf@laptop.org \
--cc=akarwar@marvell.com \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).