From: Kalle Valo <kvalo@kernel.org>
To: Emmanuel Grumbach <egrumbach@gmail.com>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
"Gregory Greenman" <gregory.greenman@intel.com>,
"Emmanuel Grumbach" <emmanuel.grumbach@intel.com>,
"Ayala Beker" <ayala.beker@intel.com>,
linux-wireless@vger.kernel.org,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Golan Ben Ami" <golan.ben.ami@intel.com>
Subject: Re: [PATCH] iwlwifi: Mark IWLMEI as broken
Date: Mon, 12 Sep 2022 14:19:24 +0300 [thread overview]
Message-ID: <871qsg96wz.fsf@kernel.org> (raw)
In-Reply-To: <CANUX_P3NRqD2YWfkFri37F982QVaCASfyz2qaicGjc9wJ6mDYQ@mail.gmail.com> (Emmanuel Grumbach's message of "Thu, 8 Sep 2022 11:27:41 +0300")
Emmanuel Grumbach <egrumbach@gmail.com> writes:
> On Wed, Sep 7, 2022 at 5:02 PM Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>>
>> From: Toke Høiland-Jørgensen <toke@redhat.com>
>>
>> The iwlmei driver breaks iwlwifi when returning from suspend; the bug
>> report[0] has been open for four months now, and now fix seems to be
>> forthcoming. Since just disabling the iwlmei driver works as a workaround,
>> let's mark the config option as broken until it can be fixed properly.
>>
>> [0] https://bugzilla.kernel.org/show_bug.cgi?id=215937
>>
>> Fixes: 2da4366f9e2c ("iwlwifi: mei: add the driver to allow cooperation with CSME")
>> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
>
> I am not very proud of this, to say the least, but unfortunately,
> despite Toke's patience and
> his willingness to provide logs and all, I couldn't find the time to fix this.
> We had tested against NetworkManager wpa_s, but not against iwd.
> From the start, we thought distro wouldn't enable this and this is why
> we disabled iwlmei by default.
I'm always saying that a Kconfig option is not a "free pass" for
anything, some people will enable Kconfig options which they don't
understand and they must not break existing features.
> This driver is meant to be used by specific groups that need this and
> they'll know how to enable this driver even if it is marked as BROKEN.
This is just a temporary solution to workaround the regression. But we
cannot have broken code forever, so I hope this is properly fixed soon
so that the workaround can be removed.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-09-12 11:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 13:44 [PATCH] iwlwifi: Mark IWLMEI as broken Toke Høiland-Jørgensen
2022-09-08 8:27 ` Emmanuel Grumbach
2022-09-08 9:18 ` Toke Høiland-Jørgensen
2022-09-12 11:19 ` Kalle Valo [this message]
2022-09-09 5:42 ` Kalle Valo
2022-09-09 6:26 ` Toke Høiland-Jørgensen
2022-09-09 9:10 ` Kalle Valo
2022-09-09 6:54 ` Emmanuel Grumbach
2022-09-12 11:24 ` wifi: " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qsg96wz.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ayala.beker@intel.com \
--cc=egrumbach@gmail.com \
--cc=emmanuel.grumbach@intel.com \
--cc=golan.ben.ami@intel.com \
--cc=gregory.greenman@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=toke@redhat.com \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox