From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] wifi: rtw89: pci: fix interrupt stuck after leaving low power mode
Date: Mon, 29 Aug 2022 19:07:21 +0300 [thread overview]
Message-ID: <871qszdoee.fsf@kernel.org> (raw)
In-Reply-To: <20220824063312.15784-1-pkshih@realtek.com> (Ping-Ke Shih's message of "Wed, 24 Aug 2022 14:33:11 +0800")
Ping-Ke Shih <pkshih@realtek.com> writes:
> We turn off interrupt in ISR, and re-enable interrupt in threadfn or
> napi_poll according to the mode it stays. If we are turning off interrupt,
> rtwpci->running flag is unset and interrupt handler stop processing even
> if it was called, so disallow to re-enable interrupt in this situation.
> Or, wifi chip doesn't trigger interrupt events anymore because interrupt
> status (ISR) isn't clear by interrupt handler anymore.
>
> Fixes: c83dcd0508e2 ("rtw89: pci: add a separate interrupt handler for low power mode")
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
> ---
> Hi Kalle,
>
> This patchset contains two patches with fixes tag, but we don't turn on
> lower power mode yet, so this patchset should go to wireless-next tree.
Very good, thanks for letting me know. This kind of info always helps.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-08-29 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 6:33 [PATCH 1/2] wifi: rtw89: pci: fix interrupt stuck after leaving low power mode Ping-Ke Shih
2022-08-24 6:33 ` [PATCH 2/2] wifi: rtw89: pci: correct TX resource checking in " Ping-Ke Shih
2022-08-29 16:07 ` Kalle Valo [this message]
2022-09-02 8:37 ` [PATCH 1/2] wifi: rtw89: pci: fix interrupt stuck after leaving " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qszdoee.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).