From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8382DCA9EA0 for ; Tue, 22 Oct 2019 11:35:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5688421872 for ; Tue, 22 Oct 2019 11:35:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="e48az/H1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388698AbfJVLfW (ORCPT ); Tue, 22 Oct 2019 07:35:22 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:30023 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388671AbfJVLfW (ORCPT ); Tue, 22 Oct 2019 07:35:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571744121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9lXUdIMpqZFihIoO9yzChXD19YUfn5jCLlrdTWpXVmA=; b=e48az/H181QGPEk5nrq5EjCQG4d4ruwJzaJRoPj56062kAO94I6R48qmODqzkJNwKATJNX XihGMdD4cmiLCR5D4ikCjwFazd8RdsGTQEiIPl4WY7ud97HNBD6H6rTeH+cgyjYxG2qdEG d411Gpy0MbvTlRh0xTSqH6S7JxFgWNM= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-341-ngypYPZ7OHSHwod_HwKkFg-1; Tue, 22 Oct 2019 07:35:19 -0400 Received: by mail-lf1-f72.google.com with SMTP id m24so3367677lfh.22 for ; Tue, 22 Oct 2019 04:35:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=5Z4MpTbIw+JCQPCzaEXbau+RX+9w+zSZ8KSShaRJy8k=; b=oyTNJyxDgpdqmS/mlQ3TmFxqxqi4kVi64l8recvIvA+tHbMmqKxko/AwJWEV6SIybL +1qwn9LOK67S9cfTmVU5oKVTwCDOCXXxG2P0evxaQLaAfb6hZ+1SwUrt0fw6V2LbKx5D 5Lur97z0JS2bIHDC7HOnz02+jQsDI0jt9QP3GNFOfn8m1t+y+2NR9prMjiT/OOK1MOda n2kFc8Cs4bD6yiP2Xz5l0Qf+jwr46H3B2TQrwInbxX9gUbGPiKY5FfJR0X/v0vHxw2Ni xmjYT75qdFhhfPxnRH8FsfRbUXJCaA/nm1dM14/OQyzktETUxBfCJVY++5RleahbSUzr wz8Q== X-Gm-Message-State: APjAAAUXa1RTBBiCeWeYHWdvfnmkZPmTcWc4G2SghvKyG/w5f2DvS9qW Og6X7UyQ+fXvm4JiOV8SvQiS3Uaf+dl0ba12UBb+L2PkP4GDGnGceq6hSNEX6MWwJuuTBjXLMaM FbalNVXE+MGUgzQ7YwRGbXJU42Jw= X-Received: by 2002:a19:6a08:: with SMTP id u8mr19884669lfu.74.1571744117868; Tue, 22 Oct 2019 04:35:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqwmGTFXAJkFuoNzgelmQogIQSog/uQu9muSz0RpmB3Wbx+A4SlxIO3hShCl4fhxL63M2txo1g== X-Received: by 2002:a19:6a08:: with SMTP id u8mr19884659lfu.74.1571744117720; Tue, 22 Oct 2019 04:35:17 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk (borgediget.toke.dk. [85.204.121.218]) by smtp.gmail.com with ESMTPSA id b67sm16614489ljf.5.2019.10.22.04.35.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2019 04:35:16 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 2DABF1804B1; Tue, 22 Oct 2019 13:35:16 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Kan Yan Cc: Johannes Berg , linux-wireless@vger.kernel.org, Make-Wifi-fast , ath10k@lists.infradead.org, John Crispin , Lorenzo Bianconi , Felix Fietkau , Rajkumar Manoharan , Kevin Hayes Subject: Re: [PATCH v4 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue In-Reply-To: References: <157148503415.2989444.7391437309981941226.stgit@toke.dk> <157148503865.2989444.7118792679603045723.stgit@toke.dk> X-Clacks-Overhead: GNU Terry Pratchett Date: Tue, 22 Oct 2019 13:35:16 +0200 Message-ID: <871rv5ovwr.fsf@toke.dk> MIME-Version: 1.0 X-MC-Unique: ngypYPZ7OHSHwod_HwKkFg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Kan Yan writes: >> + if (ieee80211_is_data_qos(hdr->frame_control)) { >> + qc =3D ieee80211_get_qos_ctl(hdr); >> + tid =3D qc[0] & 0xf; >> + ac =3D ieee80211_ac_from_tid(tid); >> + } else { >> + ac =3D IEEE80211_AC_BE; >> + } > > The tid/ac is incorrect either here or in __ieee80211_tx_status() when > tested with ath10k. The ac is set to AC_BE with test done using BK > class traffic, hence the pending airtime get updated for the wrong > txq. Hmm, I guess we could just get the ac using skb_get_queue_mapping(). I'll send an update with this fixed for you to try :) -Toke