From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F4B4C3A5A6 for ; Mon, 23 Sep 2019 09:05:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 640E421670 for ; Mon, 23 Sep 2019 09:05:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="B/VeetzC"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="B/VeetzC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731658AbfIWJFZ (ORCPT ); Mon, 23 Sep 2019 05:05:25 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:54804 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729404AbfIWJFX (ORCPT ); Mon, 23 Sep 2019 05:05:23 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id E0B5560256; Mon, 23 Sep 2019 09:05:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1569229522; bh=J0jAn93L8O6H3rjtmdAp2j3w5to8tTtp09OT+wjNbwY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=B/VeetzCNpYJW+/3tRk3t8aGIjk4kCpKSKA+XKEv+YPiyOfh6IXGzO/z8WM3ZR6JD itsoPgnqk8AnmA6rT7ZyogWU6E/hXMV7tr1EJgHhkISHWbW5zlAPRvT3W6hcOm2CEk sGDxVF4NxiOT8VWcxVge/j3pi1lyJq1PKqZgjwMk= Received: from x230.qca.qualcomm.com (37-136-106-186.rev.dnainternet.fi [37.136.106.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id E23BF60256; Mon, 23 Sep 2019 09:05:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1569229522; bh=J0jAn93L8O6H3rjtmdAp2j3w5to8tTtp09OT+wjNbwY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=B/VeetzCNpYJW+/3tRk3t8aGIjk4kCpKSKA+XKEv+YPiyOfh6IXGzO/z8WM3ZR6JD itsoPgnqk8AnmA6rT7ZyogWU6E/hXMV7tr1EJgHhkISHWbW5zlAPRvT3W6hcOm2CEk sGDxVF4NxiOT8VWcxVge/j3pi1lyJq1PKqZgjwMk= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E23BF60256 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Wen Gong Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH v5 3/8] ath10k: change max RX bundle size from 8 to 32 for sdio References: <1567679893-14029-1-git-send-email-wgong@codeaurora.org> <1567679893-14029-4-git-send-email-wgong@codeaurora.org> Date: Mon, 23 Sep 2019 12:05:17 +0300 In-Reply-To: <1567679893-14029-4-git-send-email-wgong@codeaurora.org> (Wen Gong's message of "Thu, 5 Sep 2019 18:38:08 +0800") Message-ID: <871rw79ycy.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Wen Gong writes: > The max bundle size support by firmware is 32, change it from 8 to 32 > will help performance. This results in significant performance > improvement on RX path. > > Tested with QCA6174 SDIO with firmware > WLAN.RMH.4.4.1-00007-QCARMSWP-1. > > Signed-off-by: Wen Gong [...] > --- a/drivers/net/wireless/ath/ath10k/htc.h > +++ b/drivers/net/wireless/ath/ath10k/htc.h > @@ -39,7 +39,7 @@ > * 4-byte aligned. > */ > > -#define HTC_HOST_MAX_MSG_PER_RX_BUNDLE 8 > +#define HTC_HOST_MAX_MSG_PER_RX_BUNDLE 32 > > enum ath10k_htc_tx_flags { > ATH10K_HTC_FLAG_NEED_CREDIT_UPDATE = 0x01, > @@ -48,10 +48,16 @@ enum ath10k_htc_tx_flags { > > enum ath10k_htc_rx_flags { > ATH10K_HTC_FLAGS_RECV_1MORE_BLOCK = 0x01, > - ATH10K_HTC_FLAG_TRAILER_PRESENT = 0x02, > - ATH10K_HTC_FLAG_BUNDLE_MASK = 0xF0 > + ATH10K_HTC_FLAG_TRAILER_PRESENT = 0x02 > }; > > +#define ATH10K_HTC_FLAG_BUNDLE_MASK 0xF0 > +#define ATH10K_HTC_BUNDLE_EXTRA_MASK GENMASK(3, 2) > + > +#define ATH10K_HTC_GET_BUNDLE_COUNT(flags) \ > + (FIELD_GET(ATH10K_HTC_FLAG_BUNDLE_MASK, (flags)) + \ > + (FIELD_GET(ATH10K_HTC_BUNDLE_EXTRA_MASK, (flags)) << 4)) When using FIELD_GET() there should be no need to use '<<', the main id of FIELD_GET() and BITMASK() is that there's no need do any manual shifting. So I suspect something is wrong here, but didn't have time to investigate. -- Kalle Valo