From: Kalle Valo <kvalo@codeaurora.org>
To: "Reizer\, Eyal" <eyalr@ti.com>
Cc: "linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree\@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-spi\@vger.kernel.org" <linux-spi@vger.kernel.org>,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCHv8] wlcore: spi: add wl18xx support
Date: Wed, 20 Jul 2016 10:02:13 +0300 [thread overview]
Message-ID: <871t2ovll6.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <8665E2433BC68541A24DFFCA87B70F5B36161990@DFRE01.ent.ti.com> (Eyal Reizer's message of "Wed, 20 Jul 2016 06:58:12 +0000")
"Reizer, Eyal" <eyalr@ti.com> writes:
> Add support for using with both wl12xx and wl18xx.
>
> - all wilink family needs special init command for entering wspi mode.
> extra clock cycles should be sent after the spi init command while the
> cs pin is high.
> - Use inverted chip select for sending a dummy 4 bytes command that
> completes the init stage.
>
> Signed-off-by: Eyal Reizer <eyalr@ti.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
> v1->v2:update device tree bindings configuration
> v2->v3:revert from manual gpio manipulation. use inverted chip select instead
> for sending the extra init cycle which, achieves the same hardware purpose.
> update device tree bindings docucmentation accordingly
> v3->v4: Remove redundant data form binding documentation and fix chip select
> number mismatch in wl1271 example
> v4->v5: Rebase on top of head of wireless-drivers-next
> v5->v6: Add ACKs
> v6->v7: Mail format issues
> v7->v8: Remove redundant varaible from wlcore_probe_of
I have already applied this patch, it's too late to send a new version.
Now you need to send a new patch, on top of wireless-drivers-next, which
removes the redundant variable.
--
Kalle Valo
next prev parent reply other threads:[~2016-07-20 7:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1468994768-23609-1-git-send-email-eyalr@ti.com>
2016-07-20 6:58 ` [PATCHv8] wlcore: spi: add wl18xx support Reizer, Eyal
2016-07-20 7:02 ` Kalle Valo [this message]
2016-07-20 7:04 ` Reizer, Eyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871t2ovll6.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=eyalr@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox