linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "linux-wireless\@vger.kernel.org"
	<linux-wireless@vger.kernel.org>,
	Hauke Mehrtens <hauke@hauke-m.de>, Arnd Bergmann <arnd@arndb.de>,
	"linux-arm-kernel\@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] bcma: populate bus DT subnodes as platform_device-s
Date: Thu, 23 Jul 2015 09:06:28 +0300	[thread overview]
Message-ID: <871tfzif17.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CACna6rzFYpwbzM+s-KzFQmTym4iLVn+Ap+DWgFmAZzhWKTQfJw@mail.gmail.com> ("Rafał Miłecki"'s message of "Thu, 23 Jul 2015 02:30:41 +0200")

Rafał Miłecki <zajec5@gmail.com> writes:

>> +       if (bus->host_pdev) {
>> +               struct device *dev = &bus->host_pdev->dev;
>> +
>> +               of_platform_populate(dev->of_node, of_default_bus_match_table,
>> +                                    NULL, dev);
>> +       }
>> +
>
> This caused a compile error when using bcma as module:
> ERROR: "of_default_bus_match_table" [drivers/bcma/bcma.ko] undefined!
>
> There are two options I guess:
> 1) Export of_default_bus_match_table
> 2) Use some better condition like
> if (IS_BUILTIN(CONFIG_BCMA) && bus->host_pdev)
>
> Unfortunately I'm on my long holidays right now.
>
> Hauke: do you think you can find a moment to handle this?

I can cook up a patch which uses IS_BUILTIN() so that we get the build
working again. You can fix this better once you come back.

> Sorry for the problem :|

No worries, enjoy your vacation :)

-- 
Kalle Valo

  reply	other threads:[~2015-07-23  6:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-28 15:17 [PATCH] bcma: populate bus DT subnodes as platform_device-s Rafał Miłecki
2015-06-30 21:45 ` Hauke Mehrtens
2015-07-01  4:45   ` Rafał Miłecki
2015-07-21 14:07 ` Kalle Valo
2015-07-23  0:30 ` Rafał Miłecki
2015-07-23  6:06   ` Kalle Valo [this message]
2015-07-24 16:11     ` Joachim Eastwood
2015-07-25 18:55       ` Hauke Mehrtens
2015-07-25 21:00         ` Joachim Eastwood
2015-08-02 18:03 ` Hauke Mehrtens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871tfzif17.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=arnd@arndb.de \
    --cc=hauke@hauke-m.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).