From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Simon Wunderlich <sw@simonwunderlich.de>
Cc: <ath10k@lists.infradead.org>,
<mathias.kretschmer@fokus.fraunhofer.de>,
<kgiori@qca.qualcomm.com>, <linux-wireless@vger.kernel.org>,
<sven@narfation.org>
Subject: Re: [PATCHv3-ath-resend 2/2] ath10k: add spectral scan feature
Date: Thu, 24 Jul 2014 12:29:07 +0300 [thread overview]
Message-ID: <871ttbrtp8.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1406136773-19957-1-git-send-email-sw@simonwunderlich.de> (Simon Wunderlich's message of "Wed, 23 Jul 2014 19:32:53 +0200")
Simon Wunderlich <sw@simonwunderlich.de> writes:
> Adds the spectral scan feature for ath10k. The spectral scan is triggered by
> configuring a mode through a debugfs control file. Samples can be gathered via
> another relay debugfs file.
>
> Essentially, to try it out:
>
> ip link set dev wlan0 up
> echo background > /sys/kernel/debug/ieee80211/phy0/ath10k/spectral_scan_ctl
> echo trigger > /sys/kernel/debug/ieee80211/phy0/ath10k/spectral_scan_ctl
> iw dev wlan0 scan
> echo disable > /sys/kernel/debug/ieee80211/phy0/ath10k/spectral_scan_ctl
> cat /sys/kernel/debug/ieee80211/phy0/ath10k/spectral_scan0 > samples
>
> This feature is still experimental. Based on the original RFC patch of
> Sven Eckelmann.
>
> Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
> Signed-off-by: Mathias Kretschmer <mathias.kretschmer@fokus.fraunhofer.de>
[...]
> diff --git a/drivers/net/wireless/ath/ath10k/Makefile b/drivers/net/wireless/ath/ath10k/Makefile
> index a4179f4..3241ef9 100644
> --- a/drivers/net/wireless/ath/ath10k/Makefile
> +++ b/drivers/net/wireless/ath/ath10k/Makefile
> @@ -10,6 +10,7 @@ ath10k_core-y += mac.o \
> wmi.o \
> bmi.o
>
> +ath10k_core-$(CPTCFG_ATH10K_DEBUGFS) += spectral.o
This one still uses CPTCFG_ prefix, I'll fix those.
> @@ -800,8 +800,6 @@ int ath10k_core_start(struct ath10k *ar)
> else
> ar->free_vdev_map = (1 << TARGET_NUM_VDEVS) - 1;
>
> - INIT_LIST_HEAD(&ar->arvifs);
> -
> if (!test_bit(ATH10K_FLAG_FIRST_BOOT_DONE, &ar->dev_flags)) {
> ath10k_info("%s (0x%08x, 0x%08x) fw %s api %d htt %d.%d\n",
> ar->hw_params.name,
> @@ -1084,6 +1082,12 @@ struct ath10k *ath10k_core_create(void *hif_priv, struct device *dev,
> INIT_WORK(&ar->register_work, ath10k_core_register_work);
> INIT_WORK(&ar->restart_work, ath10k_core_restart);
>
> + INIT_LIST_HEAD(&ar->arvifs);
I'm a bit suspicious about this, why is it needed?
--
Kalle Valo
next prev parent reply other threads:[~2014-07-24 9:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 15:53 [PATCHv3 0/2] ath10k spectral scan support Simon Wunderlich
2014-07-23 15:53 ` [PATCHv3 1/2] ath: Move spectral debugfs structs to shared header Simon Wunderlich
2014-07-23 15:53 ` [PATCHv3 2/2] ath10k: add spectral scan feature Simon Wunderlich
2014-07-23 17:14 ` [PATCHv3 0/2] ath10k spectral scan support Kalle Valo
2014-07-23 17:32 ` [PATCHv3-ath-resend 2/2] ath10k: add spectral scan feature Simon Wunderlich
2014-07-24 9:29 ` Kalle Valo [this message]
2014-07-24 9:34 ` Michal Kazior
2014-07-24 9:45 ` Kalle Valo
2014-07-24 9:36 ` Simon Wunderlich
2014-07-24 9:40 ` Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871ttbrtp8.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=kgiori@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mathias.kretschmer@fokus.fraunhofer.de \
--cc=sven@narfation.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).