From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Ben Greear <greearb@candelatech.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] ath10k: add vdev-id, return code to error codes
Date: Thu, 27 Feb 2014 10:43:05 +0200 [thread overview]
Message-ID: <871typj692.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <530E325E.4060503@candelatech.com> (Ben Greear's message of "Wed, 26 Feb 2014 10:28:46 -0800")
Ben Greear <greearb@candelatech.com> writes:
> On 02/13/2014 10:06 PM, Kalle Valo wrote:
>> greearb@candelatech.com writes:
>>
>>> From: Ben Greear <greearb@candelatech.com>
>>>
>>> When using multiple vdevs (stations, aps, etc), it is
>>> nice to be able to associate log messages with specific
>>> interfaces. So, add vdev-id to most logging messages.
>>> Add return code as well, where it was missing.
>>>
>>> Signed-off-by: Ben Greear <greearb@candelatech.com>
>>
>> I did some changes just to have consistent style for warning messages,
>> see my incremental diff patch below. Let me know if you agree with my
>> changes, the full patch is in ath-next-test branch.
>
> Are you wanting me to send in a revised version of this patch, or
> is it fine as previously posted?
I was planning to send v2 myself, but travelling and vacation got in the
way. I'll try to send it today.
--
Kalle Valo
next prev parent reply other threads:[~2014-02-27 8:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 19:09 [PATCH 1/2] ath10k: add vdev-id, return code to error codes greearb
2014-02-13 19:09 ` [PATCH 2/2] ath10k: do not ratelimit ath10k_warn messages greearb
2014-02-13 19:56 ` Kalle Valo
2014-02-13 20:32 ` Ben Greear
2014-02-14 6:06 ` [PATCH 1/2] ath10k: add vdev-id, return code to error codes Kalle Valo
2014-02-14 15:33 ` Ben Greear
2014-03-03 15:32 ` Kalle Valo
2014-02-26 18:28 ` Ben Greear
2014-02-27 8:43 ` Kalle Valo [this message]
2014-03-03 15:39 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871typj692.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).