* [PATCH] ath10k: make monitor vdev down before stoping it
@ 2013-09-24 12:06 Marek Puzyniak
2013-09-26 14:30 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Marek Puzyniak @ 2013-09-24 12:06 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Marek Puzyniak
Following sequence causes FW crash:
-monitor vdev up,
-monitor vdev stop,
-monitor vdev delete.
Making monitor vdev down before stoping it works ok:
-monitor vdev up,
-monitor vdev down,
-monitor vdev stop,
-monitor vdev delete.
Signed-off-by: Marek Puzyniak <marek.puzyniak@tieto.com>
---
drivers/net/wireless/ath/ath10k/mac.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 51988d9..24b94c8 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -567,12 +567,9 @@ static int ath10k_monitor_stop(struct ath10k *ar)
lockdep_assert_held(&ar->conf_mutex);
- /* For some reasons, ath10k_wmi_vdev_down() here couse
- * often ath10k_wmi_vdev_stop() to fail. Next we could
- * not run monitor vdev and driver reload
- * required. Don't see such problems we skip
- * ath10k_wmi_vdev_down() here.
- */
+ ret = ath10k_wmi_vdev_down(ar, ar->monitor_vdev_id);
+ if (ret)
+ ath10k_warn("Monitor vdev down failed: %d\n", ret);
ret = ath10k_wmi_vdev_stop(ar, ar->monitor_vdev_id);
if (ret)
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ath10k: make monitor vdev down before stoping it
2013-09-24 12:06 [PATCH] ath10k: make monitor vdev down before stoping it Marek Puzyniak
@ 2013-09-26 14:30 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2013-09-26 14:30 UTC (permalink / raw)
To: Marek Puzyniak; +Cc: ath10k, linux-wireless
Marek Puzyniak <marek.puzyniak@tieto.com> writes:
> Following sequence causes FW crash:
> -monitor vdev up,
> -monitor vdev stop,
> -monitor vdev delete.
> Making monitor vdev down before stoping it works ok:
> -monitor vdev up,
> -monitor vdev down,
> -monitor vdev stop,
> -monitor vdev delete.
>
> Signed-off-by: Marek Puzyniak <marek.puzyniak@tieto.com>
Thanks, applied.
--
Kalle Valo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-26 14:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-24 12:06 [PATCH] ath10k: make monitor vdev down before stoping it Marek Puzyniak
2013-09-26 14:30 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).