From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>, Ryan Hsu <ryanhsu@qca.qualcomm.com>
Subject: Re: [PATCH 5/6] ath6kl: Fix a debugfs crash for USB devices
Date: Fri, 15 Feb 2013 12:30:30 +0200 [thread overview]
Message-ID: <871uchamyh.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1360834689-11187-1-git-send-email-mohammed@qca.qualcomm.com> (Mohammed Shafi Shajakhan's message of "Thu, 14 Feb 2013 15:08:09 +0530")
Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com> writes:
> From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
>
> Credit distribution stats is currently implemented
> only for SDIO. This fixes a crash in debugfs for
> USB interface.
>
> BUG: unable to handle kernel NULL pointer dereference at (null)
> IP: [<f91c2048>] read_file_credit_dist_stats+0x38/0x330 [ath6kl_core]
> *pde = b62bd067
> Oops: 0000 [#1] SMP
[...]
> --- a/drivers/net/wireless/ath/ath6kl/debug.c
> +++ b/drivers/net/wireless/ath/ath6kl/debug.c
> @@ -658,6 +658,9 @@ static ssize_t read_file_credit_dist_stats(struct file *file,
> unsigned int buf_len, len = 0;
> ssize_t ret_cnt;
>
> + if (ar->hif_type != ATH6KL_HIF_TYPE_SDIO)
> + return -EINVAL;
Actually I think it would be better not to even create the debugfs when
using sdio.
--
Kalle Valo
next prev parent reply other threads:[~2013-02-15 10:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 9:38 [PATCH 5/6] ath6kl: Fix a debugfs crash for USB devices Mohammed Shafi Shajakhan
2013-02-15 10:30 ` Kalle Valo [this message]
2013-02-15 11:26 ` Mohammed Shafi Shajakhan
2013-02-15 11:43 ` Kalle Valo
2013-02-15 14:00 ` Mohammed Shafi Shajakhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871uchamyh.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mohammed@qca.qualcomm.com \
--cc=ryanhsu@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).