From: Kalle Valo <kvalo@adurom.com>
To: Jonathan Guerin <jonathan@guerin.id.au>
Cc: Bruno Randolf <br1@einfach.org>,
ath5k-devel@lists.ath5k.org,
linux-wireless <linux-wireless@vger.kernel.org>,
Nick Kossifidis <mickflemm@gmail.com>
Subject: Re: [ath5k-devel] [ath5k] Incorrect value for ACK_TIMEOUT
Date: Wed, 15 Sep 2010 10:17:13 +0300 [thread overview]
Message-ID: <871v8v5vd2.fsf@purkki.adurom.net> (raw)
In-Reply-To: <AANLkTimHDXpazQ_rEXw81cdHLRmUpAA+r_tHGdvGOVYW@mail.gmail.com> (Jonathan Guerin's message of "Wed\, 15 Sep 2010 14\:11\:39 +1000")
Jonathan Guerin <jonathan@guerin.id.au> writes:
>> the thing is, like bob said, that we don't really know much about what the HW
>> expects in some of these registers, so unless you can prove your changes to be
>> correct - e.g. by measurements which fit the theoretical model better, or by
>> better thruput, it's hard to say if they are correct or not.
>>
>> so before you worry about how to make a correct patch, just go ahead and
>> change those initvals to what you believe they should be. if it improves
>> something, let's talk about how to correctly fix it.
>
> I don't mean to be a smart-ass, but wouldn't setting the correct
> values here decrease the throughput? I'm not quite sure how to verify
> an improvement, other than get the card to contend for the medium with
> another known-working card? Does this sound reasonable?
Yes, it does sound reasonable. You might get throughput increase by
violating the spec.
--
Kalle Valo
next prev parent reply other threads:[~2010-09-15 7:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 1:56 [ath5k] Incorrect value for ACK_TIMEOUT Jonathan Guerin
2010-09-15 2:30 ` [ath5k-devel] " Bruno Randolf
2010-09-15 3:01 ` Jonathan Guerin
2010-09-15 3:09 ` Jonathan Guerin
2010-09-15 3:16 ` Bruno Randolf
2010-09-15 3:28 ` Jonathan Guerin
2010-09-15 3:45 ` Bruno Randolf
2010-09-15 4:11 ` Jonathan Guerin
2010-09-15 7:17 ` Kalle Valo [this message]
2010-09-15 7:27 ` Jonathan Guerin
2010-09-15 7:32 ` Bruno Randolf
2010-09-15 7:36 ` Kalle Valo
2010-09-15 10:00 ` Jonathan Guerin
2010-09-15 10:41 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871v8v5vd2.fsf@purkki.adurom.net \
--to=kvalo@adurom.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=br1@einfach.org \
--cc=jonathan@guerin.id.au \
--cc=linux-wireless@vger.kernel.org \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).