From: Kalle Valo <kalle.valo@iki.fi>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Michael Buesch <mb@bu3sch.de>,
kecsa@kutfo.hit.bme.hu, linux-wireless@vger.kernel.org
Subject: Re: hwtkip hangs on b43
Date: Sun, 24 Jan 2010 14:37:35 +0200 [thread overview]
Message-ID: <871vhfptkg.fsf@purkki.valot.fi> (raw)
In-Reply-To: <1264332771.23766.24.camel@johannes.local> (Johannes Berg's message of "Sun\, 24 Jan 2010 12\:32\:50 +0100")
Johannes Berg <johannes@sipsolutions.net> writes:
>> >>> We can just remove the lock and add a comment explaining why it is not locked...
>
> Mind you, it won't work on SDIO hardware since the callback cannot
> sleep, contrary to what Kalle documented :(
Oh, sorry about that. Back then I tried to be careful and I checked
the context few calls up. But I didn't check far enough and realise
that all RX code is inside rcu critical section.
I'll send a patch to fix this shortly.
> Why is it not giving everybody warnings in might_sleep()?
Very good question. We should get warnings from both iwlwifi and b43,
but I have no idea why we haven't heard anything.
--
Kalle Valo
next prev parent reply other threads:[~2010-01-24 12:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-23 8:46 hwtkip hangs on b43 kecsa
2010-01-23 17:20 ` Larry Finger
2010-01-23 17:47 ` Johannes Berg
2010-01-23 18:19 ` Michael Buesch
2010-01-23 18:34 ` Larry Finger
2010-01-23 18:47 ` Michael Buesch
2010-01-23 18:48 ` Johannes Berg
2010-01-23 18:53 ` Johannes Berg
2010-01-23 19:00 ` Michael Buesch
2010-01-23 19:31 ` Larry Finger
2010-01-23 19:38 ` Michael Buesch
2010-01-24 5:58 ` Larry Finger
2010-01-24 11:32 ` Johannes Berg
2010-01-24 11:45 ` Michael Buesch
2010-01-24 11:47 ` Johannes Berg
2010-01-24 11:52 ` Michael Buesch
2010-01-24 12:37 ` Kalle Valo [this message]
2010-01-25 10:43 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871vhfptkg.fsf@purkki.valot.fi \
--to=kalle.valo@iki.fi \
--cc=Larry.Finger@lwfinger.net \
--cc=johannes@sipsolutions.net \
--cc=kecsa@kutfo.hit.bme.hu \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).