From: rtm@csail.mit.edu
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: linux-wireless@vger.kernel.org
Subject: Re: divide by zero in ath9k_htc_choose_bslot()
Date: Mon, 31 Mar 2025 10:17:31 -0400 [thread overview]
Message-ID: <87261.1743430651@localhost> (raw)
In-Reply-To: Your message of "Mon, 31 Mar 2025 14:26:02 +0200." <87semtgzdx.fsf@toke.dk>
Toke,
Yes, your fix makes the problem go away for me, and does seem
like the better approach.
Robert
> diff --git i/drivers/net/wireless/ath/ath9k/htc_drv_beacon.c w/drivers/net/wireless/ath/ath9k/htc_drv_beacon.c
> index 547634f82183..81fa7cbad892 100644
> --- i/drivers/net/wireless/ath/ath9k/htc_drv_beacon.c
> +++ w/drivers/net/wireless/ath/ath9k/htc_drv_beacon.c
> @@ -290,6 +290,9 @@ void ath9k_htc_swba(struct ath9k_htc_priv *priv,
> struct ath_common *common = ath9k_hw_common(priv->ah);
> int slot;
>
> + if (!priv->cur_beacon_conf.enable_beacon)
> + return;
> +
> if (swba->beacon_pending != 0) {
> priv->beacon.bmisscnt++;
> if (priv->beacon.bmisscnt > BSTUCK_THRESHOLD) {
next prev parent reply other threads:[~2025-03-31 14:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-27 18:16 divide by zero in ath9k_htc_choose_bslot() rtm
2025-03-31 12:26 ` Toke Høiland-Jørgensen
2025-03-31 14:17 ` rtm [this message]
2025-04-01 18:13 ` Jeff Johnson
2025-04-02 9:09 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87261.1743430651@localhost \
--to=rtm@csail.mit.edu \
--cc=linux-wireless@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox