* [PATCH] wifi: ath12k: Fix for out-of bound access error
@ 2024-10-15 19:21 Karol Przybylski
2024-10-21 9:07 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Karol Przybylski @ 2024-10-15 19:21 UTC (permalink / raw)
To: kvalo, jjohnson; +Cc: Karol Przybylski, linux-wireless, ath12k, linux-kernel
Size of array passed to print_array_to_buf_index is decremented by 1
Discovered in coverity scan, CID 1600742
Signed-off-by: Karol Przybylski <karprzy7@gmail.com>
---
drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c b/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
index b2be7dade79f..74767ba9ec2b 100644
--- a/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
+++ b/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
@@ -1550,7 +1550,7 @@ ath12k_htt_print_tx_selfgen_ax_stats_tlv(const void *tag_buf, u16 tag_len,
le32_to_cpu(htt_stats_buf->ax_mu_mimo_ndp));
len += print_array_to_buf_index(buf, len, "ax_mu_mimo_brpollX_tried = ", 1,
htt_stats_buf->ax_mu_mimo_brpoll,
- ATH12K_HTT_TX_NUM_AX_MUMIMO_USER_STATS, "\n");
+ ATH12K_HTT_TX_NUM_AX_MUMIMO_USER_STATS-1, "\n");
len += scnprintf(buf + len, buf_len - len, "ax_basic_trigger = %u\n",
le32_to_cpu(htt_stats_buf->ax_basic_trigger));
len += scnprintf(buf + len, buf_len - len, "ax_ulmumimo_total_trigger = %u\n",
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] wifi: ath12k: Fix for out-of bound access error
2024-10-15 19:21 [PATCH] wifi: ath12k: Fix for out-of bound access error Karol Przybylski
@ 2024-10-21 9:07 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2024-10-21 9:07 UTC (permalink / raw)
To: Karol Przybylski; +Cc: jjohnson, linux-wireless, ath12k, linux-kernel
Karol Przybylski <karprzy7@gmail.com> writes:
> Size of array passed to print_array_to_buf_index is decremented by 1
>
> Discovered in coverity scan, CID 1600742
>
> Signed-off-by: Karol Przybylski <karprzy7@gmail.com>
> ---
> drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c b/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
> index b2be7dade79f..74767ba9ec2b 100644
> --- a/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
> +++ b/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c
> @@ -1550,7 +1550,7 @@ ath12k_htt_print_tx_selfgen_ax_stats_tlv(const void *tag_buf, u16 tag_len,
> le32_to_cpu(htt_stats_buf->ax_mu_mimo_ndp));
> len += print_array_to_buf_index(buf, len, "ax_mu_mimo_brpollX_tried = ", 1,
> htt_stats_buf->ax_mu_mimo_brpoll,
> - ATH12K_HTT_TX_NUM_AX_MUMIMO_USER_STATS, "\n");
> + ATH12K_HTT_TX_NUM_AX_MUMIMO_USER_STATS-1, "\n");
A space before and after '-', please.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-21 9:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-15 19:21 [PATCH] wifi: ath12k: Fix for out-of bound access error Karol Przybylski
2024-10-21 9:07 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).