From: Kalle Valo <kvalo@kernel.org>
To: Christian Lamparter <chunkeey@gmail.com>
Cc: Nikita Zhandarovich <n.zhandarovich@fintech.ru>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
syzkaller-bugs@googlegroups.com, lvc-project@linuxtesting.org,
syzbot+0ae4804973be759fa420@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] wifi: carl9170: add a proper sanity check for endpoints
Date: Fri, 26 Apr 2024 07:58:58 +0300 [thread overview]
Message-ID: <8734r8sorx.fsf@kernel.org> (raw)
In-Reply-To: <ccbdc170-149d-442c-8167-2b05c8cf93b2@gmail.com> (Christian Lamparter's message of "Thu, 25 Apr 2024 22:37:04 +0200")
Christian Lamparter <chunkeey@gmail.com> writes:
> On 4/22/24 8:33 PM, Nikita Zhandarovich wrote:
>> Syzkaller reports [1] hitting a warning which is caused by presence
>> of a wrong endpoint type at the URB sumbitting stage. While there
>> was a check for a specific 4th endpoint, since it can switch types
>> between bulk and interrupt, other endpoints are trusted implicitly.
>> Similar warning is triggered in a couple of other syzbot issues [2].
>> Fix the issue by doing a comprehensive check of all endpoints
>> taking into account difference between high- and full-speed
>> configuration.
>> This patch has not been tested on real hardware.
>
> Oh, I've tested the original patch on real hardware ;). You can remove that line.
BTW I can remove that line, no need to resend because of this.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-04-26 4:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 18:33 [PATCH v2] wifi: carl9170: add a proper sanity check for endpoints Nikita Zhandarovich
2024-04-25 20:37 ` Christian Lamparter
2024-04-26 4:58 ` Kalle Valo [this message]
2024-04-26 17:02 ` Christian Lamparter
2024-04-29 17:07 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734r8sorx.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=chunkeey@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=n.zhandarovich@fintech.ru \
--cc=syzbot+0ae4804973be759fa420@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox