Re: [wireless-next:main 32/56] drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5623:40: sparse: sparse: invalid assignment: |=

[Kalle Valo <kvalo@kernel.org>]

Ping-Ke Shih <pkshih@realtek.com> writes:

>> -----Original Message-----
>> From: Kalle Valo <kvalo@kernel.org>
>> Sent: Tuesday, January 16, 2024 2:23 PM
>> To: kernel test robot <lkp@intel.com>
>> Cc: Martin Kaistra <martin.kaistra@linutronix.de>; oe-kbuild-all@lists.linux.dev; Johannes Berg
>> <johannes@sipsolutions.net>; linux-wireless@vger.kernel.org; Ping-Ke Shih <pkshih@realtek.com>
>> Subject: Re: [wireless-next:main 32/56] drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5623:40:
>> sparse: sparse: invalid assignment: |=
>> 
>> kernel test robot <lkp@intel.com> writes:
>> 
>> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
>> > head:   ece90a8622320bf5a24d3326da1f8e109891573c
>> > commit: b837f78fbffa5f8e7e7c59879db54793abf161ec [32/56] wifi: rtl8xxxu: add hw crypto support for AP
>> mode
>> > config: riscv-randconfig-r132-20240116
>> (https://download.01.org/0day-ci/archive/20240116/202401161318.YtXoCkjU-lkp@intel.com/config)
>> > compiler: riscv64-linux-gcc (GCC) 13.2.0
>> > reproduce:
>> (https://download.01.org/0day-ci/archive/20240116/202401161318.YtXoCkjU-lkp@intel.com/reproduce)
>> >
>> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> > the same patch/commit), kindly add following tags
>> > | Reported-by: kernel test robot <lkp@intel.com>
>> > | Closes: https://lore.kernel.org/oe-kbuild-all/202401161318.YtXoCkjU-lkp@intel.com/
>> >
>> > sparse warnings: (new ones prefixed by >>)
>> >>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5623:40: sparse: sparse: invalid assignment: |=
>> >    drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5623:40: sparse:    left side has type
>> restricted __le32
>> >    drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5623:40: sparse:    right side has type
>> unsigned long
>> 
>> Martin, could you send a fix for this ASAP?
>> 
>
> I help to prepare a patch [1]. Because sparse reports two warnings, I fix
> them by two patches in the same patchset.  
>
> [1] https://lore.kernel.org/linux-wireless/20240116080945.20172-1-pkshih@realtek.com/T/#t

Awesome, thanks Ping!

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches