From: "Antoine Beaupré" <anarcat@debian.org>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Cc: Gregory Greenman <gregory.greenman@intel.com>, ilan.peer@intel.com
Subject: Re: Microcode SW error since Linux 6.5
Date: Mon, 25 Sep 2023 14:39:32 -0400 [thread overview]
Message-ID: <8734z29jx7.fsf@angela.anarc.at> (raw)
In-Reply-To: <0190dde1170bd1ee810e99b9799678f4f5b8f30e.camel@sipsolutions.net>
On 2023-09-25 08:03:09, Johannes Berg wrote:
> On Sun, 2023-09-24 at 22:43 -0400, Antoine Beaupré wrote:
[...]
>> > I think something like this, perhaps:
>> >
>> > --- a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
>> > +++ b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
>> > @@ -2342,7 +2342,7 @@ iwl_mvm_scan_umac_fill_general_p_v12(struct iwl_mvm *mvm,
>> > if (gen_flags & IWL_UMAC_SCAN_GEN_FLAGS_V2_FRAGMENTED_LMAC2)
>> > gp->num_of_fragments[SCAN_HB_LMAC_IDX] = IWL_SCAN_NUM_OF_FRAGS;
>> >
>> > - if (version < 12) {
>> > + if (version < 12 || !iwl_mvm_has_mld_api(mvm->fw)) {
>> > gp->scan_start_mac_or_link_id = scan_vif->id;
>> > } else {
>> > struct iwl_mvm_vif_link_info *link_info;
>>
>> Interesting! In any case, the firmware is certainly out of date in
>> Debian stable, and I guess it's to be expected that having it out of
>> sync with the running kernel is a Bad Idea, it's just not something I've
>> thought of before. :)
>
> Did that patch help?
I haven't tried, to be honest. It's been years since I compiled a
kernel, so I haven't actually seriously considered it. But I can
definitely put that on my list if it would be useful for you!
Quite a bit of scaffolding to build to get back down there though...
>> Thanks for the debugging, I'll make sure to keep the firmware and kernel
>> in better lockstep in the future!
>
> Yes, you can ... but I mean, we still do want to consider this a bug, I
> think, since we explicitly built the thing to load the older firmware.
> It just gets _far_ less testing.
Got it, happy to play guinea pig a little further if that's useful.
a.
--
The desire to sacrifice an entire lifetime to the noblest of ideals
serves no purpose if one works alone.
- Che Guevara
next prev parent reply other threads:[~2023-09-25 18:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 17:24 Microcode SW error since Linux 6.5 Antoine Beaupré
2023-09-21 19:10 ` Greenman, Gregory
2023-09-21 19:29 ` Johannes Berg
2023-09-25 2:43 ` Antoine Beaupré
2023-09-25 6:03 ` Johannes Berg
2023-09-25 18:39 ` Antoine Beaupré [this message]
2023-09-25 19:03 ` Johannes Berg
2023-10-03 11:52 ` Linux regression tracking (Thorsten Leemhuis)
2023-10-04 7:51 ` Greenman, Gregory
2023-10-04 8:35 ` Linux regression tracking (Thorsten Leemhuis)
2023-10-04 13:12 ` Kalle Valo
2023-10-04 15:34 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734z29jx7.fsf@angela.anarc.at \
--to=anarcat@debian.org \
--cc=gregory.greenman@intel.com \
--cc=ilan.peer@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox