* [PATCH net-next] wlcore: sdio: Use module_sdio_driver macro to simplify the code
@ 2023-08-15 7:54 Li Zetao
2023-08-21 12:53 ` Kalle Valo
0 siblings, 1 reply; 4+ messages in thread
From: Li Zetao @ 2023-08-15 7:54 UTC (permalink / raw)
To: kvalo; +Cc: lizetao1, linux-wireless
Use the module_sdio_driver macro to simplify the code, which is the
same as declaring with module_init() and module_exit().
Signed-off-by: Li Zetao <lizetao1@huawei.com>
---
drivers/net/wireless/ti/wlcore/sdio.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/net/wireless/ti/wlcore/sdio.c b/drivers/net/wireless/ti/wlcore/sdio.c
index cf8d909fa826..f0686635db46 100644
--- a/drivers/net/wireless/ti/wlcore/sdio.c
+++ b/drivers/net/wireless/ti/wlcore/sdio.c
@@ -442,18 +442,7 @@ static struct sdio_driver wl1271_sdio_driver = {
#endif
};
-static int __init wl1271_init(void)
-{
- return sdio_register_driver(&wl1271_sdio_driver);
-}
-
-static void __exit wl1271_exit(void)
-{
- sdio_unregister_driver(&wl1271_sdio_driver);
-}
-
-module_init(wl1271_init);
-module_exit(wl1271_exit);
+module_sdio_driver(wl1271_sdio_driver);
module_param(dump, bool, 0600);
MODULE_PARM_DESC(dump, "Enable sdio read/write dumps.");
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] wlcore: sdio: Use module_sdio_driver macro to simplify the code
2023-08-15 7:54 [PATCH net-next] wlcore: sdio: Use module_sdio_driver macro to simplify the code Li Zetao
@ 2023-08-21 12:53 ` Kalle Valo
2023-08-21 14:03 ` [PATCH -next v2] wifi: " Li Zetao
0 siblings, 1 reply; 4+ messages in thread
From: Kalle Valo @ 2023-08-21 12:53 UTC (permalink / raw)
To: Li Zetao; +Cc: linux-wireless
Li Zetao <lizetao1@huawei.com> writes:
> Use the module_sdio_driver macro to simplify the code, which is the
> same as declaring with module_init() and module_exit().
>
> Signed-off-by: Li Zetao <lizetao1@huawei.com>
wlcore patches go to wireless-next, not net-next.
"wifi:" missing from subject but I can add that.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH -next v2] wifi: wlcore: sdio: Use module_sdio_driver macro to simplify the code
2023-08-21 12:53 ` Kalle Valo
@ 2023-08-21 14:03 ` Li Zetao
2023-08-25 9:59 ` Kalle Valo
0 siblings, 1 reply; 4+ messages in thread
From: Li Zetao @ 2023-08-21 14:03 UTC (permalink / raw)
To: kvalo; +Cc: linux-wireless, lizetao1
Use the module_sdio_driver macro to simplify the code, which is the
same as declaring with module_init() and module_exit().
Signed-off-by: Li Zetao <lizetao1@huawei.com>
---
v1 -> v2: Add "wifi:" to the subject.
v1: https://lore.kernel.org/all/20230815075419.1067635-1-lizetao1@huawei.com/
drivers/net/wireless/ti/wlcore/sdio.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/net/wireless/ti/wlcore/sdio.c b/drivers/net/wireless/ti/wlcore/sdio.c
index cf8d909fa826..f0686635db46 100644
--- a/drivers/net/wireless/ti/wlcore/sdio.c
+++ b/drivers/net/wireless/ti/wlcore/sdio.c
@@ -442,18 +442,7 @@ static struct sdio_driver wl1271_sdio_driver = {
#endif
};
-static int __init wl1271_init(void)
-{
- return sdio_register_driver(&wl1271_sdio_driver);
-}
-
-static void __exit wl1271_exit(void)
-{
- sdio_unregister_driver(&wl1271_sdio_driver);
-}
-
-module_init(wl1271_init);
-module_exit(wl1271_exit);
+module_sdio_driver(wl1271_sdio_driver);
module_param(dump, bool, 0600);
MODULE_PARM_DESC(dump, "Enable sdio read/write dumps.");
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-25 10:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-15 7:54 [PATCH net-next] wlcore: sdio: Use module_sdio_driver macro to simplify the code Li Zetao
2023-08-21 12:53 ` Kalle Valo
2023-08-21 14:03 ` [PATCH -next v2] wifi: " Li Zetao
2023-08-25 9:59 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).