From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7806AC47088 for ; Fri, 2 Dec 2022 12:36:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233525AbiLBMgw (ORCPT ); Fri, 2 Dec 2022 07:36:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233521AbiLBMgw (ORCPT ); Fri, 2 Dec 2022 07:36:52 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52E44A519C; Fri, 2 Dec 2022 04:36:51 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EFE8D622A8; Fri, 2 Dec 2022 12:36:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A557C433C1; Fri, 2 Dec 2022 12:36:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669984610; bh=JrVlUhmbfEf3yx1LFj69LbM293k8DEwjw6TruUjw5Dc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Npr23a1vBexZkiiLKy3Pnz3Iv7m20sJySy1/QsAPyn4jy1rtCIBih+QtA4/i/Siqi EsmR4Q5KzFygb4fiirPAavuVoN/7n9P2jJucnF4TQeJae8V9diRcZEdGelA8LV+n40 jWoXOF15N3xo3S3zSiA8m4aldXk6wcbJQZyisL3JAGqDTD/2RgYfOCaoOxLJ6HfSS3 4f2aWS7tp4sK+Tp+MSO3GJys4fHRh/DAnb7w1xPfjbNSTGqVh6E+3zeueJpTreyetK pNkwvLJyYM9vB3bmWfrLmICwMVuuDx3H07qZpaBbQPvypokaJyfSyzuZ3/W8eDNoEZ DymCxv0z3rMbA== From: Kalle Valo To: Sascha Hauer Cc: Jakub Kicinski , linux-wireless@vger.kernel.org, Neo Jou , Hans Ulli Kroll , Ping-Ke Shih , Yan-Hsuan Chuang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Blumenstingl , kernel@pengutronix.de, Johannes Berg , Alexander Hochbaum , Da Xue , Po-Hao Huang , Viktor Petrenko Subject: Re: [PATCH v4 08/11] wifi: rtw88: Add rtw8821cu chipset support References: <20221129100754.2753237-1-s.hauer@pengutronix.de> <20221129100754.2753237-9-s.hauer@pengutronix.de> <20221129081753.087b7a35@kernel.org> <20221202080952.GG9130@pengutronix.de> Date: Fri, 02 Dec 2022 14:36:41 +0200 In-Reply-To: <20221202080952.GG9130@pengutronix.de> (Sascha Hauer's message of "Fri, 2 Dec 2022 09:09:52 +0100") Message-ID: <87359y3rty.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Sascha Hauer writes: > On Tue, Nov 29, 2022 at 08:17:53AM -0800, Jakub Kicinski wrote: >> On Tue, 29 Nov 2022 11:07:51 +0100 Sascha Hauer wrote: >> > +config RTW88_8821CU >> > + tristate "Realtek 8821CU USB wireless network adapter" >> > + depends on USB >> > + select RTW88_CORE >> > + select RTW88_USB >> > + select RTW88_8821C >> > + help >> > + Select this option will enable support for 8821CU chipset >> > + >> > + 802.11ac USB wireless network adapter >> >> Those kconfig knobs add so little code, why not combine them all into >> one? No point bothering the user with 4 different questions with amount >> to almost nothing. > > I tend to agree here. I followed the pattern used with PCI support here, > but I also think that we don't need to be able to select all chips > individually. The following should be enough: > > config RTW88_PCI > tristate > depends on PCI > default y > > config RTW88_USB > tristate > depends on USB > default y > > Still I'd like to continue with the current pattern to not block merging > of the USB support with this topic. > > I could create a follow up patch though if that's desired. Yeah, a follow up patch is a good idea. Best to get USB support commited first, after that we can discuss improvements. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches