From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: Kevin Yang <kevin_yang@realtek.com>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 4/6] wifi: rtw89: mac: process MCC related C2H
Date: Tue, 29 Nov 2022 07:35:10 +0200 [thread overview]
Message-ID: <8735a25nn5.fsf@kernel.org> (raw)
In-Reply-To: <6444fb9949e14656b3ccf0adb6babb63@realtek.com> (Ping-Ke Shih's message of "Tue, 29 Nov 2022 00:22:40 +0000")
Ping-Ke Shih <pkshih@realtek.com> writes:
>> -----Original Message-----
>> From: Kalle Valo <kvalo@kernel.org>
>> Sent: Monday, November 28, 2022 9:31 PM
>> To: Ping-Ke Shih <pkshih@realtek.com>
>> Cc: Kevin Yang <kevin_yang@realtek.com>; linux-wireless@vger.kernel.org
>> Subject: Re: [PATCH 4/6] wifi: rtw89: mac: process MCC related C2H
>>
>> Ping-Ke Shih <pkshih@realtek.com> writes:
>>
>> > From: Zong-Zhe Yang <kevin_yang@realtek.com>
>> >
>> > Process C2H(s) related to MCC (multi-channel concurrency). These handling,
>> > which either call rtw89_complete_cond() or show message in debug mode, can
>> > be considered atomic/lock-free. So, they should be safe to be processed
>> > directly after C2H pre-check in previous patch.
>> >
>> > Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
>> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
>>
>> [...]
>>
>> > +static
>> > +void (* const rtw89_mac_c2h_mcc_handler[])(struct rtw89_dev *rtwdev,
>> > + struct sk_buff *c2h, u32 len) = {
>> > + [RTW89_MAC_C2H_FUNC_MCC_RCV_ACK] = rtw89_mac_c2h_mcc_rcv_ack,
>> > + [RTW89_MAC_C2H_FUNC_MCC_REQ_ACK] = rtw89_mac_c2h_mcc_req_ack,
>> > + [RTW89_MAC_C2H_FUNC_MCC_TSF_RPT] = rtw89_mac_c2h_mcc_tsf_rpt,
>> > + [RTW89_MAC_C2H_FUNC_MCC_STATUS_RPT] = rtw89_mac_c2h_mcc_status_rpt,
>> > +};
>>
>> static const?
>>
>
> These are function pointers, so const is before instance name,
> i.e. '... const rtw89_mac_c2h_mcc_handler ..'
Ah indeed, missed that. Thanks.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-11-29 5:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 5:10 [PATCH 0/6] wifi: rtw89: preparation of MCC Ping-Ke Shih
2022-11-18 5:10 ` [PATCH 1/6] wifi: rtw89: rfk: rename rtw89_mcc_info to rtw89_rfk_mcc_info Ping-Ke Shih
2022-11-18 5:10 ` [PATCH 2/6] wifi: rtw89: check if atomic before queuing c2h Ping-Ke Shih
2022-11-18 5:10 ` [PATCH 3/6] wifi: rtw89: introduce helpers to wait/complete on condition Ping-Ke Shih
2022-11-28 13:29 ` Kalle Valo
2022-11-29 4:18 ` Ping-Ke Shih
2022-11-18 5:10 ` [PATCH 4/6] wifi: rtw89: mac: process MCC related C2H Ping-Ke Shih
2022-11-28 13:30 ` Kalle Valo
2022-11-29 0:22 ` Ping-Ke Shih
2022-11-29 5:35 ` Kalle Valo [this message]
2022-11-18 5:10 ` [PATCH 5/6] wifi: rtw89: fw: implement MCC related H2C Ping-Ke Shih
2022-11-18 5:10 ` [PATCH 6/6] wifi: rtw89: link rtw89_vif and chanctx stuffs Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735a25nn5.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=kevin_yang@realtek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).