Re: [GIT PULL] Networking for 6.0

Re: [GIT PULL] Networking for 6.0

[Linus Torvalds]

[-- Attachment #1: Type: text/plain, Size: 843 bytes --]

Hmm. Another issue with the networking pull..

On Wed, Aug 3, 2022 at 3:15 AM Paolo Abeni <pabeni@redhat.com> wrote:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git tags/net-next-6.0
>
> Veerendranath Jakkam (5):
>       cfg80211: Indicate MLO connection info in connect and roam callbacks

This one added a

                for_each_valid_link(cr, link) {
                        if (WARN_ON_ONCE(!cr->links[link].bss))
                                break;
                }

in net/wireless/sme.c, and it seems to trigger on my brand new M2 Macbook Air.

Wireless still works fine (I'm writing this report on the machine),
but you get a scary splat:

  WARNING: CPU: 5 PID: 514 at net/wireless/sme.c:786
__cfg80211_connect_result+0x2fc/0x5c0 [cfg80211]

full call trace etc in the attachment.

               Linus

[-- Attachment #2: out --]
[-- Type: application/octet-stream, Size: 3964 bytes --]


[    3.045590] brcmfmac: brcmf_c_process_txcap_blob: TxCap blob found, loading
[    3.049486] brcmfmac: brcmf_c_process_cal_blob: Calibration blob provided by platform, loading
[    3.062293] brcmfmac: brcmf_c_preinit_dcmds: Firmware: BCM4387/7 wl0: Apr  6 2022 05:55:54 version 20.90.45.0.8.7.118 FWID 01-e7138ff2
[    3.094339] brcmfmac 0000:01:00.0 wlp1s0f0: renamed from wlan0
[    3.772749] ieee80211 phy0: brcmf_p2p_set_firmware: failed to update device address ret -52
[    3.773878] ieee80211 phy0: brcmf_p2p_create_p2pdev: set p2p_disc error
[    3.773886] ieee80211 phy0: brcmf_cfg80211_add_iface: add iface p2p-dev-wlp1s0f type 10 failed: err=-52
[    5.378614] rfkill: input handler disabled
[    5.796275] Bluetooth: RFCOMM TTY layer initialized
[    5.796281] Bluetooth: RFCOMM socket layer initialized
[    5.796284] Bluetooth: RFCOMM ver 1.11
[    8.783524] rfkill: input handler enabled
[    9.319867] ------------[ cut here ]------------
[    9.319871] WARNING: CPU: 5 PID: 514 at net/wireless/sme.c:786 __cfg80211_connect_result+0x2fc/0x5c0 [cfg80211]
[    9.319886] Modules linked in: snd_seq_dummy snd_hrtimer snd_seq snd_seq_device rfcomm nft_fib_inet nft_fib_ipv4 nft_fib_ipv6 nft_fib nft_reject_inet nf_reject_ipv6 nft_reject nft_ct nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 ip_set nf_tables nfnetlink qrtr bnep joydev hid_magicmouse hci_bcm4377 brcmfmac brcmutil bluetooth cfg80211 ecdh_generic ecc rfkill macsmc_hid hid_apple snd_soc_tas2764 apple_soc_cpufreq snd_soc_apple_mca snd_soc_apple_silicon snd_soc_simple_card_utils zram xhci_plat_hcd xhci_hcd nvmem_spmi_mfd macsmc_power rtc_macsmc macsmc_reboot dockchannel_hid simple_mfd_spmi regmap_spmi tps6598x typec pcie_apple dwc3 pci_host_common nvme_apple apple_dockchannel apple_sart udc_core apple_mailbox spmi_apple_controller pinctrl_apple_gpio clk_apple_nco apple_admac apple_dart i2c_apple btrfs raid6_pq zstd_compress ip6_tables pkcs8_key_parser fuse
[    9.319909] CPU: 5 PID: 514 Comm: kworker/u16:8 Tainted: G S      W          6.0.0-rc0-07463-g82f54edf7a49 #15
[    9.319911] Hardware name: Apple MacBook Air (13-inch, M2, 2022) (DT)
[    9.319911] Workqueue: cfg80211 cfg80211_event_work [cfg80211]
[    9.319921] pstate: 00400009 (nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[    9.319923] pc : __cfg80211_connect_result+0x2fc/0x5c0 [cfg80211]
[    9.319931] lr : __cfg80211_connect_result+0x2e4/0x5c0 [cfg80211]
[    9.319939] sp : ffff800009d23cc0
[    9.319939] x29: ffff800009d23cc0 x28: 0000000000000000 x27: 0000000000000000
[    9.319941] x26: ffff800009177000 x25: dead000000000100 x24: dead000000000122
[    9.319942] x23: ffff800009d23d08 x22: ffff00000f732008 x21: ffff00004fdc4b72
[    9.319943] x20: ffff000012f69000 x19: ffff00004fdc4818 x18: ffff00001b060db0
[    9.319944] x17: 0000000000000000 x16: 0000000000000000 x15: fffc009b0105c006
[    9.319946] x14: 18ffaa0618ffaa33 x13: 0000000000000000 x12: a33d0111f4cc0001
[    9.319947] x11: 0000fffa0000002f x10: 3262005e43420000 x9 : 0000000000000000
[    9.319948] x8 : ffff0000167e804c x7 : 0000000000000000 x6 : 0000000000000000
[    9.319949] x5 : ffff800008892068 x4 : e9be800008892068 x3 : ffff0003dacb9105
[    9.319950] x2 : 0000000000000000 x1 : ffff000001f1ca00 x0 : 0000000000000000
[    9.319951] Call trace:
[    9.319952]  __cfg80211_connect_result+0x2fc/0x5c0 [cfg80211]
[    9.319960]  cfg80211_process_wdev_events+0x140/0x180 [cfg80211]
[    9.319968]  cfg80211_process_rdev_events+0x30/0x50 [cfg80211]
[    9.319975]  cfg80211_event_work+0x28/0x40 [cfg80211]
[    9.319983]  process_one_work+0x1d4/0x33c
[    9.319987]  worker_thread+0x6c/0x430
[    9.319988]  kthread+0xe4/0xf0
[    9.319990]  ret_from_fork+0x10/0x20
[    9.319991] ---[ end trace 0000000000000000 ]---
[    9.320986] IPv6: ADDRCONF(NETDEV_CHANGE): wlp1s0f0: link becomes ready
[   10.263004] rfkill: input handler disabled
[   14.610846] systemd-journald[561]: Time jumped backwards, rotating.

Re: [GIT PULL] Networking for 6.0

[Kalle Valo]

Linus Torvalds <torvalds@linux-foundation.org> writes:

> Hmm. Another issue with the networking pull..
>
> On Wed, Aug 3, 2022 at 3:15 AM Paolo Abeni <pabeni@redhat.com> wrote:
>>
>>   git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git tags/net-next-6.0
>>
>> Veerendranath Jakkam (5):
>>       cfg80211: Indicate MLO connection info in connect and roam callbacks
>
> This one added a
>
>                 for_each_valid_link(cr, link) {
>                         if (WARN_ON_ONCE(!cr->links[link].bss))
>                                 break;
>                 }
>
> in net/wireless/sme.c, and it seems to trigger on my brand new M2 Macbook Air.
>
> Wireless still works fine (I'm writing this report on the machine),
> but you get a scary splat:
>
>   WARNING: CPU: 5 PID: 514 at net/wireless/sme.c:786
> __cfg80211_connect_result+0x2fc/0x5c0 [cfg80211]
>
> full call trace etc in the attachment.

Thanks for the report, adding also Arend and changing Johannes' email.
Unfortunately Johannes is away this week. Arend, would you be able to
look at this? I don't have any brcmfmac hardware.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [GIT PULL] Networking for 6.0

[Kalle Valo]

Kalle Valo <kvalo@kernel.org> writes:

> Linus Torvalds <torvalds@linux-foundation.org> writes:
>
>> Hmm. Another issue with the networking pull..
>>
>> On Wed, Aug 3, 2022 at 3:15 AM Paolo Abeni <pabeni@redhat.com> wrote:
>>>
>>>   git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git tags/net-next-6.0
>>>
>>> Veerendranath Jakkam (5):
>>>       cfg80211: Indicate MLO connection info in connect and roam callbacks
>>
>> This one added a
>>
>>                 for_each_valid_link(cr, link) {
>>                         if (WARN_ON_ONCE(!cr->links[link].bss))
>>                                 break;
>>                 }
>>
>> in net/wireless/sme.c, and it seems to trigger on my brand new M2 Macbook Air.
>>
>> Wireless still works fine (I'm writing this report on the machine),
>> but you get a scary splat:
>>
>>   WARNING: CPU: 5 PID: 514 at net/wireless/sme.c:786
>> __cfg80211_connect_result+0x2fc/0x5c0 [cfg80211]
>>
>> full call trace etc in the attachment.
>
> Thanks for the report, adding also Arend and changing Johannes' email.
> Unfortunately Johannes is away this week. Arend, would you be able to
> look at this? I don't have any brcmfmac hardware.

Veerendranath took a look at this and here's a quick fix:

https://patchwork.kernel.org/project/linux-wireless/patch/20220805135259.4126630-1-quic_vjakkam@quicinc.com/

Do note that this isn't tested with brcmfmac but it should work :)

Linus, do you want to take that directly or should I take it to wireless
tree? I assume with the latter you would then get it by the end of next
week.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [GIT PULL] Networking for 6.0

[Linus Torvalds]

On Fri, Aug 5, 2022 at 7:22 AM Kalle Valo <kvalo@kernel.org> wrote:
>
> Linus, do you want to take that directly or should I take it to wireless
> tree? I assume with the latter you would then get it by the end of next
> week.

This isn't holding anything up on my side for the merge window - it's
just a warning, and the machine works fine.

So there's little reason to bypass the normal channels, and getting it
to me by next week is fine.

                   Linus

Re: [GIT PULL] Networking for 6.0

[Kalle Valo]

Linus Torvalds <torvalds@linux-foundation.org> writes:

> On Fri, Aug 5, 2022 at 7:22 AM Kalle Valo <kvalo@kernel.org> wrote:
>>
>> Linus, do you want to take that directly or should I take it to wireless
>> tree? I assume with the latter you would then get it by the end of next
>> week.
>
> This isn't holding anything up on my side for the merge window - it's
> just a warning, and the machine works fine.
>
> So there's little reason to bypass the normal channels, and getting it
> to me by next week is fine.

Ok, let's do that. I now applied the fix:

https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless.git/commit/?id=baa56dfe2cdad12edb2625b2d454e205943c3402

Network folks, I'm planning to submit a pull request on Tuesday or
Wednesday. Do you still submit your pull requests to Linus on Thursdays?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [GIT PULL] Networking for 6.0

[Jakub Kicinski]

On Mon, 08 Aug 2022 11:14:48 +0300 Kalle Valo wrote:
> Ok, let's do that. I now applied the fix:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless.git/commit/?id=baa56dfe2cdad12edb2625b2d454e205943c3402
> 
> Network folks, I'm planning to submit a pull request on Tuesday or
> Wednesday. Do you still submit your pull requests to Linus on Thursdays?

With fixes, yes! Thu the 11th will be the next round.