From: Kalle Valo <kvalo@kernel.org>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: nbd@nbd.name, lorenzo.bianconi83@gmail.com,
ryder.lee@mediatek.com, shayne.chen@mediatek.com,
sean.wang@mediatek.com, linux-wireless@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] mt76: mt7921: reduce log severity levels for informative messages
Date: Fri, 10 Dec 2021 10:49:11 +0200 [thread overview]
Message-ID: <8735n0oneg.fsf@tynnyri.adurom.net> (raw)
In-Reply-To: <20211210082247.977043-1-tzungbi@google.com> (Tzung-Bi Shih's message of "Fri, 10 Dec 2021 16:22:47 +0800")
Tzung-Bi Shih <tzungbi@google.com> writes:
> "ASIC revision" and "Firmware init done" shouldn't be error messages.
> Reduces the severity level to info.
>
> Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
> ---
> drivers/net/wireless/mediatek/mt76/mt7921/mcu.c | 2 +-
> drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> index 6ada1ebe7d68..99b144fd8db5 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> @@ -882,7 +882,7 @@ static int mt7921_load_firmware(struct mt7921_dev *dev)
> dev->mt76.hw->wiphy->wowlan = &mt76_connac_wowlan_support;
> #endif /* CONFIG_PM */
>
> - dev_err(dev->mt76.dev, "Firmware init done\n");
> + dev_info(dev->mt76.dev, "Firmware init done\n");
Shouldn't that be a debug message? Hard to see how's that useful in
normal operation.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-12-10 8:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 8:22 [PATCH] mt76: mt7921: reduce log severity levels for informative messages Tzung-Bi Shih
2021-12-10 8:49 ` Kalle Valo [this message]
2021-12-10 9:19 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735n0oneg.fsf@tynnyri.adurom.net \
--to=kvalo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=nbd@nbd.name \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shayne.chen@mediatek.com \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox