From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF44BC432C0 for ; Wed, 20 Nov 2019 10:14:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 971A622311 for ; Wed, 20 Nov 2019 10:14:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SLhxv7et" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728585AbfKTKOQ (ORCPT ); Wed, 20 Nov 2019 05:14:16 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:55619 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728581AbfKTKOQ (ORCPT ); Wed, 20 Nov 2019 05:14:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574244855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rEKvOxmr/7NLtoqif+lmbtJ5Ka/hKgAKqI6KOkdaNss=; b=SLhxv7etBxUSKCeFKWjplR4RoH1gKThm7ppVoafVgJUGRGsM8/Ev9pv3zXjOcIZVStIhtF s7kkzhaEKmQqMLeiVhoRVCVB8hMkTKw4h1q1NRRtkvTZ6eZa/IYHiFEL7N1R+kbdN/EL52 c8pi7sk8C+RTq3EForONwLhmYNDypqg= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-382-_y19TmpCPzil4uxMXHaOjg-1; Wed, 20 Nov 2019 05:14:12 -0500 Received: by mail-lj1-f197.google.com with SMTP id 70so4712992ljf.13 for ; Wed, 20 Nov 2019 02:14:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=fKMBRKKpaoMlSII2moNkw+zJtmUVNSbZ+F1avrH659c=; b=qeXNxEEGOIOLYMfElFXAaaH7XjCtUNd9HxW8eIQPuKNyFZSTwPGnjuIecauhlhN0AM JP2got0rgmaC6td9pPRtC6qobFzZEzZOUCtc4ml42dVQnS3i0K0ylsQ/lH4b4Ex+DZMI p9l2h+0oW9Dms1LRYXYNJ87xdnLTZuioIz8hnbRHGeuF/wJ+PPCKXo8jo6tIBOKYJemo oPekxAPUenB5A9oazjESVkjfpijK99nSl1EGQ1dnxH72Y0VTuPKUvdRy8c/dDuUoJIoj 1Ig18+o8h9GGrO97S9Mr1Y755imeMJD92vOBDqR+pfUrz051HNiIoSev+2kvNMGUH/5T NkMw== X-Gm-Message-State: APjAAAXj14acUSG4Q/nbOCBaKKQvboYt7MXCJkhH2sfiVkeFa+nE2B47 myH1ZIZQrpArZW/9vPrfRP6E8wuNKTlJZ4ffMD68saO7FWl2MFgNewSAe0xLyl1GwnNuNDldoQn iVD54s1ocEJ08oG9HR/X3aMoDlH4= X-Received: by 2002:a2e:3009:: with SMTP id w9mr2069288ljw.74.1574244850944; Wed, 20 Nov 2019 02:14:10 -0800 (PST) X-Google-Smtp-Source: APXvYqzz0j0GllypMuFTfk3eJAjjpWU8fCBRAYfRKxpQqC34cMGuViFXOmq9cdjSIMsSAsHugcf9LA== X-Received: by 2002:a2e:3009:: with SMTP id w9mr2069278ljw.74.1574244850800; Wed, 20 Nov 2019 02:14:10 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([2a00:7660:6da:443::2]) by smtp.gmail.com with ESMTPSA id u184sm12021852lja.86.2019.11.20.02.14.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Nov 2019 02:14:09 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id E696918190F; Wed, 20 Nov 2019 11:14:08 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Kan Yan , Dave Taht Cc: Rajkumar Manoharan , Kevin Hayes , Make-Wifi-fast , linux-wireless , Yibo Zhao , John Crispin , Johannes Berg , Lorenzo Bianconi , Felix Fietkau Subject: Re: [Make-wifi-fast] [PATCH v8 0/2] Implement Airtime-based Queue Limit (AQL) In-Reply-To: References: <20191115014846.126007-1-kyan@google.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 20 Nov 2019 11:14:08 +0100 Message-ID: <8736eiam8f.fsf@toke.dk> MIME-Version: 1.0 X-MC-Unique: _y19TmpCPzil4uxMXHaOjg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Kan Yan writes: >> Those were lovely, thanks!!!! Big win. Since you are on patch v10 >> now.... Any chance you could turn ecn on and off and give it a go >> again in your next test run? >> >> >> Also: >> >> --step-size=3D.04 --socket-stats # the first is helpful to gain more >> detail, the second as to the behavior of the tcp stack. > > Thanks for the feedback! I will do more tests in a few days. > > >> Secondly - and AFTER this patchset stablizes, I'd like us to look into >> returning the codel default to 10ms or less >> from it's currently 20ms or worse setting. Tis another easy test > > Smaller CoDel "target" doesn't work well with wireless because the > dequeue behavior in wireless driver is very bursty. It is quite often > dequeues dozens of packets in one burst after one large aggregation is > completed, so smaller CoDel "target" can cause unnecessary packet > drop. It would be interesting to get some samples of the actual sojourn time as seen by CoDel in mac80211. Might be doable with bpftrace... -Toke